Add billing address as a mandatory field of Payments credit cards.

components/autofill/core/browser/credit_card_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/guid.h"
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 65 matching lines @@
 TEST(CreditCardTest, PreviewSummaryAndNetworkAndLastFourDigitsStrings) {
   // Case 0: empty credit card.
   CreditCard credit_card0(base::GenerateGUID(), "https://www.example.com/");
   base::string16 summary0 = credit_card0.Label();
   EXPECT_EQ(base::string16(), summary0);
   base::string16 obfuscated0 = credit_card0.NetworkAndLastFourDigits();
   EXPECT_EQ(ASCIIToUTF16(std::string("Card")), obfuscated0);
 
   // Case 00: Empty credit card with empty strings.
   CreditCard credit_card00(base::GenerateGUID(), "https://www.example.com/");
-  test::SetCreditCardInfo(&credit_card00, "John Dillinger", "", "", "");
+  test::SetCreditCardInfo(&credit_card00, "John Dillinger", "", "", "", "");
   base::string16 summary00 = credit_card00.Label();
   EXPECT_EQ(base::string16(ASCIIToUTF16("John Dillinger")), summary00);
   base::string16 obfuscated00 = credit_card00.NetworkAndLastFourDigits();
   EXPECT_EQ(ASCIIToUTF16(std::string("Card")), obfuscated00);
 
   // Case 1: No credit card number.
   CreditCard credit_card1(base::GenerateGUID(), "https://www.example.com/");
-  test::SetCreditCardInfo(&credit_card1, "John Dillinger", "", "01", "2010");
+  test::SetCreditCardInfo(&credit_card1, "John Dillinger", "", "01", "2010",
+                          "1");
   base::string16 summary1 = credit_card1.Label();
   EXPECT_EQ(base::string16(ASCIIToUTF16("John Dillinger")), summary1);
   base::string16 obfuscated1 = credit_card1.NetworkAndLastFourDigits();
   EXPECT_EQ(ASCIIToUTF16(std::string("Card")), obfuscated1);
 
   // Case 2: No month.
   CreditCard credit_card2(base::GenerateGUID(), "https://www.example.com/");
-  test::SetCreditCardInfo(
-      &credit_card2, "John Dillinger", "5105 1051 0510 5100", "", "2010");
+  test::SetCreditCardInfo(&credit_card2, "John Dillinger",
+                          "5105 1051 0510 5100", "", "2010", "1");
   base::string16 summary2 = credit_card2.Label();
   EXPECT_EQ(
       UTF8ToUTF16(std::string("MasterCard") + kUTF8MidlineEllipsis + "5100"),
       summary2);
   base::string16 obfuscated2 = credit_card2.NetworkAndLastFourDigits();
   EXPECT_EQ(
       UTF8ToUTF16(std::string("MasterCard") + kUTF8MidlineEllipsis + "5100"),
       obfuscated2);
 
   // Case 3: No year.
   CreditCard credit_card3(base::GenerateGUID(), "https://www.example.com/");
-  test::SetCreditCardInfo(
-      &credit_card3, "John Dillinger", "5105 1051 0510 5100", "01", "");
+  test::SetCreditCardInfo(&credit_card3, "John Dillinger",
+                          "5105 1051 0510 5100", "01", "", "1");
   base::string16 summary3 = credit_card3.Label();
   EXPECT_EQ(
       UTF8ToUTF16(std::string("MasterCard") + kUTF8MidlineEllipsis + "5100"),
       summary3);
   base::string16 obfuscated3 = credit_card3.NetworkAndLastFourDigits();
   EXPECT_EQ(
       UTF8ToUTF16(std::string("MasterCard") + kUTF8MidlineEllipsis + "5100"),
       obfuscated3);
 
   // Case 4: Have everything.
   CreditCard credit_card4(base::GenerateGUID(), "https://www.example.com/");
-  test::SetCreditCardInfo(
-      &credit_card4, "John Dillinger", "5105 1051 0510 5100", "01", "2010");
+  test::SetCreditCardInfo(&credit_card4, "John Dillinger",
+                          "5105 1051 0510 5100", "01", "2010", "1");
   base::string16 summary4 = credit_card4.Label();
   EXPECT_EQ(UTF8ToUTF16(std::string("MasterCard") + kUTF8MidlineEllipsis +
                         "5100, 01/2010"),
             summary4);
   base::string16 obfuscated4 = credit_card4.NetworkAndLastFourDigits();
   EXPECT_EQ(
       UTF8ToUTF16(std::string("MasterCard") + kUTF8MidlineEllipsis + "5100"),
       obfuscated4);
 
   // Case 5: Very long credit card
   CreditCard credit_card5(base::GenerateGUID(), "https://www.example.com/");
   test::SetCreditCardInfo(
-      &credit_card5,
-      "John Dillinger",
-      "0123456789 0123456789 0123456789 5105 1051 0510 5100", "01", "2010");
+      &credit_card5, "John Dillinger",
+      "0123456789 0123456789 0123456789 5105 1051 0510 5100", "01", "2010",
+      "1");
   base::string16 summary5 = credit_card5.Label();
   EXPECT_EQ(
       UTF8ToUTF16(std::string("Card") + kUTF8MidlineEllipsis + "5100, 01/2010"),
       summary5);
   base::string16 obfuscated5 = credit_card5.NetworkAndLastFourDigits();
   EXPECT_EQ(UTF8ToUTF16(std::string("Card") + kUTF8MidlineEllipsis + "5100"),
             obfuscated5);
 }
 
 TEST(CreditCardTest, AssignmentOperator) {
   CreditCard a(base::GenerateGUID(), "some origin");
-  test::SetCreditCardInfo(&a, "John Dillinger", "123456789012", "01", "2010");
+  test::SetCreditCardInfo(&a, "John Dillinger", "123456789012", "01", "2010",
+                          "1");
 
   // Result of assignment should be logically equal to the original profile.
   CreditCard b(base::GenerateGUID(), "some other origin");
   b = a;
   EXPECT_TRUE(a == b);
 
   // Assignment to self should not change the profile value.
   a = a;
   EXPECT_TRUE(a == b);
 }
@@ skipping 77 matching lines @@
 
         // Invalid values.
         SetExpirationDateFromStringTestCase{"13/2016", 0, 2016},
         SetExpirationDateFromStringTestCase{"16/13", 0, 2013},
         SetExpirationDateFromStringTestCase{"May-2015", 0, 0},
         SetExpirationDateFromStringTestCase{"05-/2045", 0, 0},
         SetExpirationDateFromStringTestCase{"05_2045", 0, 0}));
 
 TEST(CreditCardTest, Copy) {
   CreditCard a(base::GenerateGUID(), "https://www.example.com");
-  test::SetCreditCardInfo(&a, "John Dillinger", "123456789012", "01", "2010");
+  test::SetCreditCardInfo(&a, "John Dillinger", "123456789012", "01", "2010",
+                          base::GenerateGUID());
 
   // Clone should be logically equal to the original.
   CreditCard b(a);
   EXPECT_TRUE(a == b);
 }
 
 struct IsLocalDuplicateOfServerCardTestCase {
   CreditCard::RecordType first_card_record_type;
   const char* first_card_name;
   const char* first_card_number;
   const char* first_card_exp_mo;
   const char* first_card_exp_yr;
+  const char* first_billing_address_id;
 
   CreditCard::RecordType second_card_record_type;
   const char* second_card_name;
   const char* second_card_number;
   const char* second_card_exp_mo;
   const char* second_card_exp_yr;
+  const char* second_billing_address_id;
   const char* second_card_issuer_network;
 
   bool is_local_duplicate;
 };
 
 class IsLocalDuplicateOfServerCardTest
     : public testing::TestWithParam<IsLocalDuplicateOfServerCardTestCase> {};
 
 TEST_P(IsLocalDuplicateOfServerCardTest, IsLocalDuplicateOfServerCard) {
   auto test_case = GetParam();
   CreditCard a(base::GenerateGUID(), std::string());
   a.set_record_type(test_case.first_card_record_type);
   test::SetCreditCardInfo(
       &a, test_case.first_card_name, test_case.first_card_number,
-      test_case.first_card_exp_mo, test_case.first_card_exp_yr);
+      test_case.first_card_exp_mo, test_case.first_card_exp_yr,
+      test_case.first_billing_address_id);
 
   CreditCard b(base::GenerateGUID(), std::string());
   b.set_record_type(test_case.second_card_record_type);
   test::SetCreditCardInfo(
       &b, test_case.second_card_name, test_case.second_card_number,
-      test_case.second_card_exp_mo, test_case.second_card_exp_yr);
+      test_case.second_card_exp_mo, test_case.second_card_exp_yr,
+      test_case.second_billing_address_id);
 
   if (test_case.second_card_record_type == CreditCard::MASKED_SERVER_CARD)
     b.SetNetworkForMaskedCard(test_case.second_card_issuer_network);
 
   EXPECT_EQ(test_case.is_local_duplicate, a.IsLocalDuplicateOfServerCard(b))
       << " when comparing cards " << a.Label() << " and " << b.Label();
 }
 
 INSTANTIATE_TEST_CASE_P(
     CreditCardTest,
     IsLocalDuplicateOfServerCardTest,
     testing::Values(
-        IsLocalDuplicateOfServerCardTestCase{LOCAL_CARD, "", "", "", "",
-                                             LOCAL_CARD, "", "", "", "",
+        IsLocalDuplicateOfServerCardTestCase{LOCAL_CARD, "", "", "", "", "",
+                                             LOCAL_CARD, "", "", "", "", "",
                                              nullptr, false},
-        IsLocalDuplicateOfServerCardTestCase{LOCAL_CARD, "", "", "", "",
+        IsLocalDuplicateOfServerCardTestCase{LOCAL_CARD, "", "", "", "", "",
                                              FULL_SERVER_CARD, "", "", "", "",
-                                             nullptr, true},
+                                             "", nullptr, true},
         IsLocalDuplicateOfServerCardTestCase{FULL_SERVER_CARD, "", "", "", "",
-                                             FULL_SERVER_CARD, "", "", "", "",
-                                             nullptr, false},
+                                             "", FULL_SERVER_CARD, "", "", "",
+                                             "", "", nullptr, false},
         IsLocalDuplicateOfServerCardTestCase{
-            LOCAL_CARD, "John Dillinger", "423456789012", "01", "2010",
+            LOCAL_CARD, "John Dillinger", "423456789012", "01", "2010", "1",
             FULL_SERVER_CARD, "John Dillinger", "423456789012", "01", "2010",
-            nullptr, true},
+            "1", nullptr, true},
         IsLocalDuplicateOfServerCardTestCase{
-            LOCAL_CARD, "J Dillinger", "423456789012", "01", "2010",
+            LOCAL_CARD, "J Dillinger", "423456789012", "01", "2010", "1",
             FULL_SERVER_CARD, "John Dillinger", "423456789012", "01", "2010",
-            nullptr, false},
+            "1", nullptr, false},
         IsLocalDuplicateOfServerCardTestCase{
-            LOCAL_CARD, "", "423456789012", "01", "2010", FULL_SERVER_CARD,
-            "John Dillinger", "423456789012", "01", "2010", nullptr, true},
+            LOCAL_CARD, "", "423456789012", "01", "2010", "1", FULL_SERVER_CARD,
+            "John Dillinger", "423456789012", "01", "2010", "1", nullptr, true},
         IsLocalDuplicateOfServerCardTestCase{
-            LOCAL_CARD, "", "423456789012", "", "", FULL_SERVER_CARD,
-            "John Dillinger", "423456789012", "01", "2010", nullptr, true},
+            LOCAL_CARD, "", "423456789012", "", "", "1", FULL_SERVER_CARD,
+            "John Dillinger", "423456789012", "01", "2010", "1", nullptr, true},
         IsLocalDuplicateOfServerCardTestCase{
-            LOCAL_CARD, "", "423456789012", "", "", MASKED_SERVER_CARD,
-            "John Dillinger", "9012", "01", "2010", kVisaCard, true},
+            LOCAL_CARD, "", "423456789012", "", "", "1", MASKED_SERVER_CARD,
+            "John Dillinger", "9012", "01", "2010", "1", kVisaCard, true},
         IsLocalDuplicateOfServerCardTestCase{
-            LOCAL_CARD, "", "423456789012", "", "", MASKED_SERVER_CARD,
-            "John Dillinger", "9012", "01", "2010", kMasterCard, false},
+            LOCAL_CARD, "", "423456789012", "", "", "1", MASKED_SERVER_CARD,
+            "John Dillinger", "9012", "01", "2010", "1", kMasterCard, false},
         IsLocalDuplicateOfServerCardTestCase{
-            LOCAL_CARD, "John Dillinger", "4234-5678-9012", "01", "2010",
+            LOCAL_CARD, "John Dillinger", "4234-5678-9012", "01", "2010", "1",
             FULL_SERVER_CARD, "John Dillinger", "423456789012", "01", "2010",
-            nullptr, true}));
+            "1", nullptr, true},
+        IsLocalDuplicateOfServerCardTestCase{
+            LOCAL_CARD, "John Dillinger", "4234-5678-9012", "01", "2010", "1",
+            FULL_SERVER_CARD, "John Dillinger", "423456789012", "01", "2010",
+            "2", nullptr, false}));
 
 TEST(CreditCardTest, HasSameNumberAs) {
   CreditCard a(base::GenerateGUID(), std::string());
   CreditCard b(base::GenerateGUID(), std::string());
 
   // Empty cards have the same empty number.
   EXPECT_TRUE(a.HasSameNumberAs(b));
   EXPECT_TRUE(b.HasSameNumberAs(a));
 
   // Same number.
@@ skipping 34 matching lines @@
   a.set_guid(base::GenerateGUID());
   b.set_guid(base::GenerateGUID());
   EXPECT_EQ(0, a.Compare(b));
 
   // Origins don't count.
   a.set_origin("apple");
   b.set_origin("banana");
   EXPECT_EQ(0, a.Compare(b));
 
   // Different values produce non-zero results.
-  test::SetCreditCardInfo(&a, "Jimmy", NULL, NULL, NULL);
-  test::SetCreditCardInfo(&b, "Ringo", NULL, NULL, NULL);
+  test::SetCreditCardInfo(&a, "Jimmy", NULL, NULL, NULL, "");
+  test::SetCreditCardInfo(&b, "Ringo", NULL, NULL, NULL, "");
   EXPECT_GT(0, a.Compare(b));
   EXPECT_LT(0, b.Compare(a));
 }
 
 // This method is not compiled for iOS because these resources are not used and
 // should not be shipped.
 #if !defined(OS_IOS)
 // Test we get the correct icon for each card type.
 TEST(CreditCardTest, IconResourceId) {
   EXPECT_EQ(IDR_AUTOFILL_CC_AMEX,
@@ skipping 10 matching lines @@
             CreditCard::IconResourceId(kMirCard));
   EXPECT_EQ(IDR_AUTOFILL_CC_UNIONPAY,
             CreditCard::IconResourceId(kUnionPay));
   EXPECT_EQ(IDR_AUTOFILL_CC_VISA,
             CreditCard::IconResourceId(kVisaCard));
 }
 #endif  // #if !defined(OS_IOS)
 
 TEST(CreditCardTest, UpdateFromImportedCard) {
   CreditCard original_card(base::GenerateGUID(), "https://www.example.com");
-  test::SetCreditCardInfo(
-      &original_card, "John Dillinger", "123456789012", "09", "2017");
+  test::SetCreditCardInfo(&original_card, "John Dillinger", "123456789012",
+                          "09", "2017", "1");
 
   CreditCard a = original_card;
 
   // The new card has a different name, expiration date, and origin.
   CreditCard b = a;
   b.set_guid(base::GenerateGUID());
   b.set_origin("https://www.example.org");
   b.SetRawInfo(CREDIT_CARD_NAME_FULL, ASCIIToUTF16("J. Dillinger"));
   b.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("08"));
   b.SetRawInfo(CREDIT_CARD_EXP_4_DIGIT_YEAR, ASCIIToUTF16("2019"));
@@ skipping 134 matching lines @@
     SCOPED_TRACE(invalid_number);
     card.SetRawInfo(CREDIT_CARD_NUMBER, ASCIIToUTF16(invalid_number));
     EXPECT_FALSE(card.IsValid());
   }
 }
 
 // Verify that we preserve exactly what the user typed for credit card numbers.
 TEST(CreditCardTest, SetRawInfoCreditCardNumber) {
   CreditCard card(base::GenerateGUID(), "https://www.example.com/");
 
-  test::SetCreditCardInfo(&card, "Bob Dylan",
-                          "4321-5432-6543-xxxx", "07", "2013");
+  test::SetCreditCardInfo(&card, "Bob Dylan", "4321-5432-6543-xxxx", "07",
+                          "2013", "1");
   EXPECT_EQ(ASCIIToUTF16("4321-5432-6543-xxxx"),
             card.GetRawInfo(CREDIT_CARD_NUMBER));
 }
 
 // Verify that we can handle both numeric and named months.
 TEST(CreditCardTest, SetExpirationMonth) {
   CreditCard card(base::GenerateGUID(), "https://www.example.com/");
 
   card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("05"));
   EXPECT_EQ(ASCIIToUTF16("05"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH));
@@ skipping 251 matching lines @@
         GetCardNetworkTestCase{"9", kGenericCard, false},
 
         // Oddball case: Unknown issuer, but valid Luhn check and plausible
         // length.
         GetCardNetworkTestCase{"7000700070007000", kGenericCard, true}));
 
 TEST(CreditCardTest, LastFourDigits) {
   CreditCard card(base::GenerateGUID(), "https://www.example.com/");
   ASSERT_EQ(base::string16(), card.LastFourDigits());
 
-  test::SetCreditCardInfo(&card, "Baby Face Nelson",
-                          "5212341234123489", "01", "2010");
+  test::SetCreditCardInfo(&card, "Baby Face Nelson", "5212341234123489", "01",
+                          "2010", "1");
   ASSERT_EQ(base::ASCIIToUTF16("3489"), card.LastFourDigits());
 
   card.SetRawInfo(CREDIT_CARD_NUMBER, ASCIIToUTF16("3489"));
   ASSERT_EQ(base::ASCIIToUTF16("3489"), card.LastFourDigits());
 
   card.SetRawInfo(CREDIT_CARD_NUMBER, ASCIIToUTF16("489"));
   ASSERT_EQ(base::ASCIIToUTF16("489"), card.LastFourDigits());
 }
 
 // Verifies that a credit card should be updated.
@@ skipping 149 matching lines @@
   };
   base::Time kArbitraryTime;
   EXPECT_TRUE(
       base::Time::FromLocalExploded(kTestDateTimeExploded, &kArbitraryTime));
 
   // Test for added to chrome/chromium.
   CreditCard credit_card0(base::GenerateGUID(), "https://www.example.com");
   credit_card0.set_use_count(1);
   credit_card0.set_use_date(kArbitraryTime - base::TimeDelta::FromDays(1));
   test::SetCreditCardInfo(&credit_card0, "John Dillinger",
-                          "423456789012" /* Visa */, "01", "2021");
+                          "423456789012" /* Visa */, "01", "2021", "1");
 
   // Test for last used date.
   CreditCard credit_card1(base::GenerateGUID(), "https://www.example.com");
   test::SetCreditCardInfo(&credit_card1, "Clyde Barrow",
-                          "347666888555" /* American Express */, "04", "2021");
+                          "347666888555" /* American Express */, "04", "2021",
+                          "1");
   credit_card1.set_use_count(10);
   credit_card1.set_use_date(kArbitraryTime - base::TimeDelta::FromDays(10));
 
   // Test for last used more than one year ago.
   CreditCard credit_card2(base::GenerateGUID(), "https://www.example.com");
   credit_card2.set_use_count(5);
   credit_card2.set_use_date(kArbitraryTime - base::TimeDelta::FromDays(366));
   test::SetCreditCardInfo(&credit_card2, "Bonnie Parker",
-                          "518765432109" /* Mastercard */, "12", "2021");
+                          "518765432109" /* Mastercard */, "12", "2021", "1");
 
   static const struct {
     const char* show_expiration_date;
     const std::string& app_locale;
     base::string16 added_to_autofill_date;
     base::string16 last_used_date;
     base::string16 last_used_year_ago;
   } kTestCases[] = {
       // only show last used date.
       {"false", "en_US", ASCIIToUTF16("Added Dec 09"),
@@ skipping 18 matching lines @@
               credit_card0.GetLastUsedDateForDisplay(test_case.app_locale));
     EXPECT_EQ(test_case.last_used_date,
               credit_card1.GetLastUsedDateForDisplay(test_case.app_locale));
     EXPECT_EQ(test_case.last_used_year_ago,
               credit_card2.GetLastUsedDateForDisplay(test_case.app_locale));
     variation_params_.ClearAllVariationParams();
   }
 }
 
 }  // namespace autofill