third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h - Issue 2849463005: Refactor ImageBuffer to make OffscreenCanvas match HTMLCanvasElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

Issue 2849463005: Refactor ImageBuffer to make OffscreenCanvas match HTMLCanvasElement (Closed)

Patch Set: x Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp ('k') | third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

index c515145aaced8e23fc909c56a2a529c7b829ded0..1f994a34aecebcf366194bba3ee2b09f4c45314e 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

@@ -59,6 +59,9 @@ class MODULES_EXPORT OffscreenCanvasRenderingContext2D final

PassRefPtr<Image> GetImage(AccelerationHint, SnapshotReason) const final;

ImageData* ToImageData(SnapshotReason) override;

void Reset() override;

+ void RestoreCanvasMatrixClipStack(PaintCanvas* c) const override {

+ RestoreMatrixClipStack(c);

+ }

// BaseRenderingContext2D implementation

bool OriginClean() const final;

@@ -107,9 +110,6 @@ class MODULES_EXPORT OffscreenCanvasRenderingContext2D final

}

private:

- bool needs_matrix_clip_restore_ = false;

- std::unique_ptr<ImageBuffer> image_buffer_;

bool IsPaintable() const final;

RefPtr<StaticBitmapImage> TransferToStaticBitmapImage();