third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp - Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp b/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

index 97db44975b780be679fa16a003ed5e73e527b1b9..19dc916361d22a35effe112ea746f0fe67b38b9c 100644

--- a/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

+++ b/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

@@ -175,7 +175,7 @@ TEST_F(LinkSelectionTest, HandCursorDuringLinkDrag) {

kSendDownEvent);

main_frame_->GetFrame()

->LocalFrameRoot()

- ->GetEventHandler()

+ .GetEventHandler()

.ScheduleCursorUpdate();

testing::RunDelayedTasks(50);

const auto& cursor =

@@ -188,7 +188,7 @@ TEST_F(LinkSelectionTest, CaretCursorOverLinkDuringSelection) {

WebInputEvent::kAltKey, kSendDownEvent);

main_frame_->GetFrame()

->LocalFrameRoot()

- ->GetEventHandler()

+ .GetEventHandler()

.ScheduleCursorUpdate();

testing::RunDelayedTasks(50);

const auto& cursor =

@@ -208,7 +208,7 @@ TEST_F(LinkSelectionTest, HandCursorOverLinkAfterContextMenu) {

// Hide context menu.

frame->GetPage()->GetContextMenuController().ClearContextMenu();

- frame->LocalFrameRoot()->GetEventHandler().ScheduleCursorUpdate();

+ frame->LocalFrameRoot().GetEventHandler().ScheduleCursorUpdate();

testing::RunDelayedTasks(50);

const auto& cursor =

main_frame_->GetFrame()->GetChromeClient().LastSetCursorForTesting();