third_party/WebKit/Source/core/page/CreateWindow.cpp - Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/CreateWindow.cpp

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/CreateWindow.cpp

diff --git a/third_party/WebKit/Source/core/page/CreateWindow.cpp b/third_party/WebKit/Source/core/page/CreateWindow.cpp

index 2d2321c054a47ad2d183d89d4dc3d7fbb4d97b23..afa0cff05ab1655ee658e9711fde61ead04f999f 100644

--- a/third_party/WebKit/Source/core/page/CreateWindow.cpp

+++ b/third_party/WebKit/Source/core/page/CreateWindow.cpp

@@ -158,7 +158,7 @@ static Frame* CreateWindowHelper(LocalFrame& opener_frame,

if (opener_frame.GetSettings() &&

!opener_frame.GetSettings()->GetSupportsMultipleWindows())

- window = opener_frame.Tree().Top();

+ window = &opener_frame.Tree().Top();

}

if (window) {