Fix Instantiation equivalence

Fix Instantiation equivalence

Instantiations of abstract native classes need to be marked as
Instantiation.ABSTRACTLY_INSTANTIATED.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/c3e28939b11b0c3351469daa1dc854e6b98eb3e9

[Johnni Winther, 2017-05-02 10:29:39]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-02 20:10:24]

lgtm

https://codereview.chromium.org/2849363003/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/element_world_builder.dart (right):

https://codereview.chromium.org/2849363003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/element_world_builder.dart:70: if (!cls.isAbstract
|| isNative) {
minor nit, might be a bit more readable to not duplicate 'isNative' here and
below, and to move the declaration of kind here. For example:


Instantiation kind =
   isNative ? ABSTRACTLY : (isAbstract ? UNINSTANTIATED : DIRECTLY);

or
Instantiation kind;
if (isNative) {
  kind = ABSTRACTLY;
} else if (isAbstract) {
  kind = UNINSTANTIATED;
} else {
  kind = DIRECTLY;
}

[Johnni Winther, 2017-05-03 09:05:25]

Description was changed from

==========
Fix Instantiation equivalence

Instantiations of abstract native classes need to be marked as
Instantiation.ABSTRACTLY_INSTANTIATED.
==========

to

==========
Fix Instantiation equivalence

Instantiations of abstract native classes need to be marked as
Instantiation.ABSTRACTLY_INSTANTIATED.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c3e28939b11b0c3351469daa1dc854e6b98eb3e9
==========

[Johnni Winther, 2017-05-03 09:05:27]

Committed patchset #2 (id:20001) manually as
c3e28939b11b0c3351469daa1dc854e6b98eb3e9 (presubmit successful).

[Johnni Winther, 2017-05-03 09:06:52]

https://codereview.chromium.org/2849363003/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/element_world_builder.dart (right):

https://codereview.chromium.org/2849363003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/element_world_builder.dart:70: if (!cls.isAbstract
|| isNative) {
On 2017/05/02 20:10:24, Siggi Cherem (dart-lang) wrote:
> minor nit, might be a bit more readable to not duplicate 'isNative' here and
> below, and to move the declaration of kind here. For example:
> 
> 
> Instantiation kind =
>    isNative ? ABSTRACTLY : (isAbstract ? UNINSTANTIATED : DIRECTLY);
> 
> or
> Instantiation kind;
> if (isNative) {
>   kind = ABSTRACTLY;
> } else if (isAbstract) {
>   kind = UNINSTANTIATED;
> } else {
>   kind = DIRECTLY;
> }
> 

Done.