cache SkImage::Info calculation in lazypixelref

cache SkImage::Info calculation in lazypixelref

BUG=
R=scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11893

[scroggo, 2013-10-21 18:34:17]

https://codereview.chromium.org/28493003/diff/1/src/lazy/SkLazyPixelRef.h
File src/lazy/SkLazyPixelRef.h (right):

https://codereview.chromium.org/28493003/diff/1/src/lazy/SkLazyPixelRef.h#new...
src/lazy/SkLazyPixelRef.h:75: const SkImage::Info* getInfo();
Could you add comments that fInfo should never be used directly, and getInfo
should be called instead?

https://codereview.chromium.org/28493003/diff/1/src/lazy/SkLazyPixelRef.h#new...
src/lazy/SkLazyPixelRef.h:77: SkImage::Info               fInfo;
Style nit: fields before methods

[reed1, 2013-10-21 18:46:10]

https://codereview.chromium.org/28493003/diff/1/src/lazy/SkLazyPixelRef.h
File src/lazy/SkLazyPixelRef.h (right):

https://codereview.chromium.org/28493003/diff/1/src/lazy/SkLazyPixelRef.h#new...
src/lazy/SkLazyPixelRef.h:75: const SkImage::Info* getInfo();
On 2013/10/21 18:34:17, scroggo wrote:
> Could you add comments that fInfo should never be used directly, and getInfo
> should be called instead?

Done.

https://codereview.chromium.org/28493003/diff/1/src/lazy/SkLazyPixelRef.h#new...
src/lazy/SkLazyPixelRef.h:77: SkImage::Info               fInfo;
On 2013/10/21 18:34:17, scroggo wrote:
> Style nit: fields before methods

Done.

[scroggo, 2013-10-21 18:49:23]

Thanks for the comments/name changes.

lgtm with one style nit - you've moved the method before the fields, instead of
after them.

https://codereview.chromium.org/28493003/diff/70001/src/lazy/SkLazyPixelRef.h
File src/lazy/SkLazyPixelRef.h (right):

https://codereview.chromium.org/28493003/diff/70001/src/lazy/SkLazyPixelRef.h...
src/lazy/SkLazyPixelRef.h:69: const SkImage::Info* getCachedInfo();
style nit: other fields before methods.

[reed1, 2013-10-21 18:58:22]

Committed patchset #3 manually as r11893 (presubmit successful).