Infer types of bool/null/string literals.

Infer types of bool/null/string literals.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/6885aea0dbd9d856da4f697ca69fd62a2b26b74e

[Paul Berry, 2017-05-01 22:03:44]

lgtm

https://codereview.chromium.org/2849293002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):

https://codereview.chromium.org/2849293002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:247: return
inferrer.inferStringLiteral(typeContext, typeNeeded);
This works for now, but in the long run it will need to recurse into the
subexpressions in order to handle stuff like:

f(x) {
  if (x is int) {
    return "$x"; // (1)
  }
}

(the kernel object for the reference to `x` at (1) needs to have its
promotedType field set to `int`, and that will only happen if we recurse into
the subexpression).

Would you mind adding a TODO comment?

[scheglov, 2017-05-02 02:33:38]

Description was changed from

==========
Infer types of bool/null/string literals.

R=paulberry@google.com
BUG=
==========

to

==========
Infer types of bool/null/string literals.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/6885aea0dbd9d856da4f697ca69fd62a2b26b74e
==========

[scheglov, 2017-05-02 02:33:39]

Committed patchset #1 (id:1) manually as
6885aea0dbd9d856da4f697ca69fd62a2b26b74e (presubmit successful).

[scheglov, 2017-05-02 02:35:21]

https://codereview.chromium.org/2849293002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):

https://codereview.chromium.org/2849293002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:247: return
inferrer.inferStringLiteral(typeContext, typeNeeded);
On 2017/05/01 22:03:44, Paul Berry wrote:
> This works for now, but in the long run it will need to recurse into the
> subexpressions in order to handle stuff like:
> 
> f(x) {
>   if (x is int) {
>     return "$x"; // (1)
>   }
> }
> 
> (the kernel object for the reference to `x` at (1) needs to have its
> promotedType field set to `int`, and that will only happen if we recurse into
> the subexpression).
> 
> Would you mind adding a TODO comment?

Done.
I ended up removing testing for StringConcatenation at all, because with
analyzer we do report the promoted type, but not in front_end yet.