Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2849273002: [GN] Fix prebuilt sdk detection on Windows (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/prebuilt_dart_sdk.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 7 months ago (2017-05-01 21:09:49 UTC) #2
rmacnak
lgtm
3 years, 7 months ago (2017-05-01 21:10:57 UTC) #3
zra
3 years, 7 months ago (2017-05-01 21:41:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef2dad515ab49167384e7f4e8c5a1199c3dd22b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698