Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2849253002: Fix bugs found while working on tests (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 3 chunks +11 lines, -3 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart View 2 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-01 20:42:43 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-01 20:44:48 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-02 13:15:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9eee213363407e7d9f2117f1fe9857bf39ecd973 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698