Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2849183002: Revert "Add support for building patched_sdk and platform.dill for dart2js:" (Closed)

Created:
3 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add support for building patched_sdk and platform.dill for dart2js:" This reverts commit 714523b103598d49295fa06b4ad13c6917c50399. TBR=ahe@google.com,vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/e9cd0b0fa568db8a96477530e2d3bf4c458e0f76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -506 lines) Patch
D pkg/compiler/lib/src/kernel/fasta_support.dart View 1 chunk +0 lines, -148 lines 0 comments Download
D pkg/compiler/tool/generate_kernel.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta.dart View 2 chunks +1 line, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 3 chunks +5 lines, -17 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 3 chunks +12 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/directive_listener.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/target_implementation.dart View 2 chunks +0 lines, -11 lines 0 comments Download
M pkg/front_end/lib/src/fasta/translate_uri.dart View 2 chunks +8 lines, -29 lines 0 comments Download
M pkg/front_end/tool/_fasta/generate_dart_libraries.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 3 chunks +2 lines, -9 lines 0 comments Download
M runtime/vm/BUILD.gn View 3 chunks +42 lines, -7 lines 0 comments Download
M tools/patch_sdk.dart View 4 chunks +110 lines, -147 lines 0 comments Download
M utils/compiler/BUILD.gn View 2 chunks +0 lines, -9 lines 0 comments Download
D utils/generate_patch_sdk.gni View 1 chunk +0 lines, -71 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as e9cd0b0fa568db8a96477530e2d3bf4c458e0f76 (presubmit successful).
3 years, 7 months ago (2017-05-01 17:29:33 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 7 months ago (2017-05-01 17:31:08 UTC) #3
ahe
What broke?
3 years, 7 months ago (2017-05-02 06:30:25 UTC) #4
Siggi Cherem (dart-lang)
3 years, 7 months ago (2017-05-02 19:14:45 UTC) #5
Message was sent while issue was closed. 
On 2017/05/02 06:30:25, ahe wrote:
> What broke?


The dart and fuschia bots started failing because of the issue Zach described in
the other CL: I had a path resolution in the .gn files that created some
canonicalization issues of the GN rules: GN thought I was loading different
rules for //runtime/bin:target and /local/path/to/dart/runtime/bin:target. That
made GN load a .gn file twice (I think), which then created conflicts with
itself. The offending dependency was under a condition, so I didn't trigger
under my build configuration locally on my machine.

Powered by Google App Engine
This is Rietveld 408576698