chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc - Issue 2849143002: webshare: Small refactor of WebShare (OnceCallback, const&, and alias)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc

Issue 2849143002: webshare: Small refactor of WebShare (OnceCallback, const&, and alias) (Closed)

Patch Set: Move alias and use OnceCallback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_dialogs.h ('K') | « chrome/browser/ui/views/webshare/webshare_target_picker_view.cc ('k') | chrome/browser/webshare/share_service_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc

diff --git a/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc b/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc

index dc57d740962c8a7513496f12dc48eae3ec658bde..cb598db1fb62120a720ccdbbfebb5219fb0b957e 100644

--- a/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc

+++ b/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc

@@ -61,8 +61,8 @@ class WebShareTargetPickerViewTest : public views::ViewsTestBase {

// Creates the WebShareTargetPickerView (available as view()).

void CreateView(const std::vector<std::pair<base::string16, GURL>>& targets) {

view_ = new WebShareTargetPickerView(

- targets, base::Bind(&WebShareTargetPickerViewTest::OnCallback,

- base::Unretained(this)));

+ targets, base::BindOnce(&WebShareTargetPickerViewTest::OnCallback,

+ base::Unretained(this)));

constrained_window::CreateBrowserModalDialogViews(

view_, parent_widget_->GetNativeWindow())

->Show();

@@ -83,7 +83,7 @@ class WebShareTargetPickerViewTest : public views::ViewsTestBase {

const base::Optional<std::string>& result() { return result_; }

private:

- void OnCallback(base::Optional<std::string> result) {

+ void OnCallback(const base::Optional<std::string>& result) {

result_ = result;

if (quit_closure_)

quit_closure_.Run();