Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: chrome/browser/ui/views/webshare/webshare_target_picker_view.cc

Issue 2849143002: webshare: Small refactor of WebShare (OnceCallback, const&, and alias) (Closed)
Patch Set: improve comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/webshare/webshare_target_picker_view.h" 5 #include "chrome/browser/ui/views/webshare/webshare_target_picker_view.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/ui/views/harmony/chrome_layout_provider.h" 8 #include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"
9 #include "chrome/grit/generated_resources.h" 9 #include "chrome/grit/generated_resources.h"
10 #include "components/constrained_window/constrained_window_views.h" 10 #include "components/constrained_window/constrained_window_views.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 ")"); 59 ")");
60 } 60 }
61 61
62 void TargetPickerTableModel::SetObserver(ui::TableModelObserver* observer) {} 62 void TargetPickerTableModel::SetObserver(ui::TableModelObserver* observer) {}
63 63
64 namespace chrome { 64 namespace chrome {
65 65
66 void ShowWebShareTargetPickerDialog( 66 void ShowWebShareTargetPickerDialog(
67 gfx::NativeWindow parent_window, 67 gfx::NativeWindow parent_window,
68 const std::vector<std::pair<base::string16, GURL>>& targets, 68 const std::vector<std::pair<base::string16, GURL>>& targets,
69 const base::Callback<void(base::Optional<std::string>)>& callback) { 69 const chrome::WebShareTargetPickerCallback& callback) {
70 constrained_window::CreateBrowserModalDialogViews( 70 constrained_window::CreateBrowserModalDialogViews(
71 new WebShareTargetPickerView(targets, callback), parent_window) 71 new WebShareTargetPickerView(targets, callback), parent_window)
72 ->Show(); 72 ->Show();
73 } 73 }
74 74
75 } // namespace chrome 75 } // namespace chrome
76 76
77 WebShareTargetPickerView::WebShareTargetPickerView( 77 WebShareTargetPickerView::WebShareTargetPickerView(
78 const std::vector<std::pair<base::string16, GURL>>& targets, 78 const std::vector<std::pair<base::string16, GURL>>& targets,
79 const base::Callback<void(base::Optional<std::string>)>& close_callback) 79 const chrome::WebShareTargetPickerCallback& close_callback)
80 : targets_(targets), 80 : targets_(targets),
81 table_model_(base::MakeUnique<TargetPickerTableModel>(&targets_)), 81 table_model_(base::MakeUnique<TargetPickerTableModel>(&targets_)),
82 close_callback_(close_callback) { 82 close_callback_(close_callback) {
83 const int panel_margin = ChromeLayoutProvider::Get()->GetDistanceMetric( 83 const int panel_margin = ChromeLayoutProvider::Get()->GetDistanceMetric(
84 DISTANCE_PANEL_CONTENT_MARGIN); 84 DISTANCE_PANEL_CONTENT_MARGIN);
85 views::BoxLayout* layout = 85 views::BoxLayout* layout =
86 new views::BoxLayout(views::BoxLayout::kVertical, panel_margin, 86 new views::BoxLayout(views::BoxLayout::kVertical, panel_margin,
87 panel_margin, views::kRelatedControlVerticalSpacing); 87 panel_margin, views::kRelatedControlVerticalSpacing);
88 SetLayoutManager(layout); 88 SetLayoutManager(layout);
89 89
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 return true; 160 return true;
161 } 161 }
162 162
163 void WebShareTargetPickerView::OnSelectionChanged() { 163 void WebShareTargetPickerView::OnSelectionChanged() {
164 GetDialogClientView()->UpdateDialogButtons(); 164 GetDialogClientView()->UpdateDialogButtons();
165 } 165 }
166 166
167 void WebShareTargetPickerView::OnDoubleClick() { 167 void WebShareTargetPickerView::OnDoubleClick() {
168 GetDialogClientView()->AcceptWindow(); 168 GetDialogClientView()->AcceptWindow();
169 } 169 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698