Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: third_party/WebKit/Source/core/events/PointerEventFactory.cpp

Issue 2849083002: Add pointer id to the WebMouseEvent's constructors (Closed)
Patch Set: webmouseidd Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/PointerEventFactory.cpp
diff --git a/third_party/WebKit/Source/core/events/PointerEventFactory.cpp b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
index 2bbb8654d16dd90a4ce7f35ef1766e82490ffa2c..f65a4c68a8a0b61e8496476431d99803994a3f2e 100644
--- a/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
+++ b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
@@ -276,9 +276,7 @@ PointerEvent* PointerEventFactory::Create(
if (pointer_event_name == EventTypeNames::pointermove) {
HeapVector<Member<PointerEvent>> coalesced_pointer_events;
for (const auto& coalesced_mouse_event : coalesced_mouse_events) {
- // TODO(crbug.com/694742): We will set the id from low-level OS events
- // and enable this DCHECK again.
- // DCHECK_EQ(mouseEvent.id, coalescedMouseEvent.id);
+ DCHECK_EQ(mouse_event.id, coalesced_mouse_event.id);
DCHECK_EQ(mouse_event.pointer_type, coalesced_mouse_event.pointer_type);
PointerEventInit coalesced_event_init = pointer_event_init;

Powered by Google App Engine
This is Rietveld 408576698