content/renderer/accessibility/blink_ax_tree_source.cc - Issue 2849063002: Forward BrowserAccessibilityWin::get_accKeyboardShortcut to the platform node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 2849063002: Forward BrowserAccessibilityWin::get_accKeyboardShortcut to the platform node (Closed)

Patch Set: Add has check to ensure we don't override key shortcut Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index 923e6390c78eb9355d877c34176b18f747a77e88..a2ccde49bb8564cd473c6187953d86871872c8df 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -560,8 +560,9 @@ void BlinkAXTreeSource::SerializeNode(WebAXObject src,

dst->AddStringAttribute(ui::AX_ATTR_LANGUAGE, src.Language().Utf8());

}

- if (src.KeyboardShortcut().length()) {

- dst->AddStringAttribute(ui::AX_ATTR_SHORTCUT,

+ if (src.KeyboardShortcut().length() &&

+ !dst->HasStringAttribute(ui::AX_ATTR_KEY_SHORTCUTS)) {

+ dst->AddStringAttribute(ui::AX_ATTR_KEY_SHORTCUTS,

src.KeyboardShortcut().Utf8());

}