content/renderer/render_frame_impl.h - Issue 2849043002: Send AndroidOverlay routing token from WMPI to AVDA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 2849043002: Send AndroidOverlay routing token from WMPI to AVDA. (Closed)

Patch Set: maybe fixed macos Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 0b981590a3b35afe89923905e99eb534d7edb46a..e55f0c09f2b4076ed360247e18d9a68f53d49db8 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -1146,7 +1146,7 @@ class CONTENT_EXPORT RenderFrameImpl

// Send |callback| our AndroidOverlay routing token when it arrives. We may

// call |callback| before returning.

- void RequestOverlayRoutingToken(const media::RoutingTokenCallback& callback);

+ void RequestOverlayRoutingToken(media::RoutingTokenCallback callback);

tguilbert 2017/05/08 23:10:28 Should this still be passed as a const ref?

liberato (no reviews please) 2017/05/09 16:55:37 const ref is now used when the desired behavior is

// Ask the host to send our AndroidOverlay routing token to us.

void RequestOverlayRoutingTokenFromHost();