Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: runtime/bin/BUILD.gn

Issue 2848943003: [infra] Assembles the SDK using GN rather than create_sdk.py (Closed)
Patch Set: Fix for Windows Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/BUILD.gn
diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn
index e053aa5cab0e0037bb1c1dd9b8ed8505e2e8a5af..14b5d3f3d7f374791ccd64a7b1abf28776d7d953 100644
--- a/runtime/bin/BUILD.gn
+++ b/runtime/bin/BUILD.gn
@@ -319,7 +319,7 @@ executable("gen_snapshot") {
]
}
- if (defined(is_fuchsia) && is_fuchsia) {
+ if (is_fuchsia) {
libs = [ "launchpad" ]
}
}
@@ -410,7 +410,7 @@ template("dart_io") {
deps += [ "//third_party/boringssl" ]
}
- if (defined(is_fuchsia) && is_fuchsia) {
+ if (is_fuchsia) {
libs = [ "launchpad" ]
}
@@ -426,7 +426,7 @@ template("dart_io") {
"log.h",
] + extra_sources
- if (is_linux || is_win || (defined(is_fuchsia) && is_fuchsia)) {
+ if (is_linux || is_win || is_fuchsia) {
if (dart_use_fallback_root_certificates) {
sources += [ "//third_party/root_certificates/root_certificates.cc" ]
} else {
@@ -606,7 +606,7 @@ template("dart_executable") {
]
}
- if (defined(is_fuchsia) && is_fuchsia) {
+ if (is_fuchsia) {
libs = [ "launchpad" ]
}
}
@@ -682,7 +682,7 @@ dart_executable("dart_bootstrap") {
]
}
-if (defined(is_fuchsia) && is_fuchsia) {
+if (is_fuchsia) {
hello_fuchsia_source = rebase_path("../tests/vm/dart/hello_fuchsia_test.dart")
copy("hello_fuchsia") {
@@ -761,7 +761,7 @@ action("generate_snapshot_test_dat_file") {
}
executable("run_vm_tests") {
- if (defined(is_fuchsia) && (is_fuchsia || is_fuchsia_host)) {
+ if (is_fuchsia || is_fuchsia_host) {
testonly = true
}
« no previous file with comments | « runtime/BUILD.gn ('k') | runtime/observatory/BUILD.gn » ('j') | tools/create_sdk.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698