Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: third_party/WebKit/public/web/WebTextCheckingResult.h

Issue 2848943002: Allow storing multiple replacements on SpellCheckResult (Closed)
Patch Set: Change back to original quote replacement behavior, update tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebTextCheckingResult.h
diff --git a/third_party/WebKit/public/web/WebTextCheckingResult.h b/third_party/WebKit/public/web/WebTextCheckingResult.h
index 4694aa6cdf574bae436d690ca2c897b6ea5028d2..ba1955d5e058973ac912eac66fcad82274eaaf40 100644
--- a/third_party/WebKit/public/web/WebTextCheckingResult.h
+++ b/third_party/WebKit/public/web/WebTextCheckingResult.h
@@ -33,6 +33,7 @@
#include "../platform/WebCommon.h"
#include "../platform/WebString.h"
+#include "../platform/WebVector.h"
rlanday 2017/05/17 22:23:58 aelias, question for you since you're a third_part
#include "WebTextDecorationType.h"
namespace blink {
@@ -44,14 +45,15 @@ struct WebTextCheckingResult {
WebTextCheckingResult()
: decoration(kWebTextDecorationTypeSpelling), location(0), length(0) {}
- WebTextCheckingResult(WebTextDecorationType decoration,
- int location,
- int length,
- const WebString& replacement = WebString())
+ WebTextCheckingResult(
+ WebTextDecorationType decoration,
+ int location,
+ int length,
+ const WebVector<WebString>& replacements = WebVector<WebString>())
: decoration(decoration),
location(location),
length(length),
- replacement(replacement) {}
+ replacements(replacements) {}
#if BLINK_IMPLEMENTATION
operator TextCheckingResult() const;
@@ -60,7 +62,7 @@ struct WebTextCheckingResult {
WebTextDecorationType decoration;
int location;
int length;
- WebString replacement;
+ WebVector<WebString> replacements;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698