Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: components/spellcheck/common/spellcheck_result.h

Issue 2848943002: Allow storing multiple replacements on SpellCheckResult (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SPELLCHECK_COMMON_SPELLCHECK_RESULT_H_ 5 #ifndef COMPONENTS_SPELLCHECK_COMMON_SPELLCHECK_RESULT_H_
6 #define COMPONENTS_SPELLCHECK_COMMON_SPELLCHECK_RESULT_H_ 6 #define COMPONENTS_SPELLCHECK_COMMON_SPELLCHECK_RESULT_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <vector>
9 10
10 #include "base/strings/string16.h" 11 #include "base/strings/string16.h"
11 12
12 // This class mirrors blink::WebTextCheckingResult which holds a 13 // This class mirrors blink::WebTextCheckingResult which holds a
13 // misspelled range inside the checked text. It also contains a 14 // misspelled range inside the checked text. It also contains a
14 // possible replacement of the misspelling if it is available. 15 // possible replacement of the misspelling if it is available.
15 struct SpellCheckResult { 16 struct SpellCheckResult {
16 enum Decoration { 17 enum Decoration {
17 // Red underline for misspelled words. 18 // Red underline for misspelled words.
18 SPELLING = 1 << 1, 19 SPELLING = 1 << 1,
19 20
20 // Gray underline for correctly spelled words that are incorrectly used in 21 // Gray underline for correctly spelled words that are incorrectly used in
21 // their context. 22 // their context.
22 GRAMMAR = 1 << 2, 23 GRAMMAR = 1 << 2,
23 }; 24 };
24 25
25 explicit SpellCheckResult(Decoration d = SPELLING, 26 explicit SpellCheckResult(
26 int loc = 0, 27 Decoration d = SPELLING,
groby-ooo-7-16 2017/04/28 23:45:55 Can we just kill the defaults here?
rlanday 2017/05/01 23:25:07 Seems that these are needed for IPC::ReadParam() t
27 int len = 0, 28 int loc = 0,
28 const base::string16& rep = base::string16()) 29 int len = 0,
29 : decoration(d), location(loc), length(len), replacement(rep) {} 30 const std::vector<base::string16>& rep = std::vector<base::string16>());
31 ~SpellCheckResult();
32 SpellCheckResult(const SpellCheckResult&);
30 33
31 Decoration decoration; 34 Decoration decoration;
32 int location; 35 int location;
33 int length; 36 int length;
34 base::string16 replacement; 37 std::vector<base::string16> replacements;
35 }; 38 };
36 39
37 #endif // COMPONENTS_SPELLCHECK_COMMON_SPELLCHECK_RESULT_H_ 40 #endif // COMPONENTS_SPELLCHECK_COMMON_SPELLCHECK_RESULT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698