chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm - Issue 284893003: Move bookmarks/core/... to bookmarks/...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm

Issue 284893003: Move bookmarks/core/... to bookmarks/... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing errors reported by presubmit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "base/mac/scoped_nsobject.h"	5 #import "base/mac/scoped_nsobject.h"

6 #include "base/strings/string16.h"	6 #include "base/strings/string16.h"

7 #include "chrome/browser/bookmarks/bookmark_model_factory.h"	7 #include "chrome/browser/bookmarks/bookmark_model_factory.h"

8 #include "chrome/browser/ui/browser.h"	8 #include "chrome/browser/ui/browser.h"

9 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h"	9 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h"

10 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h"	10 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h"

11 #include "chrome/test/base/testing_profile.h"	11 #include "chrome/test/base/testing_profile.h"

12 #include "components/bookmarks/core/browser/bookmark_model.h"	12 #include "components/bookmarks/browser/bookmark_model.h"

13 #include "components/bookmarks/core/browser/bookmark_utils.h"	13 #include "components/bookmarks/browser/bookmark_utils.h"

14 #include "testing/gtest/include/gtest/gtest.h"	14 #include "testing/gtest/include/gtest/gtest.h"

15	15

16 @interface FakeBookmarkMenuController : BookmarkMenuCocoaController {	16 @interface FakeBookmarkMenuController : BookmarkMenuCocoaController {

17 @public	17 @public

18 const BookmarkNode* nodes_[2];	18 const BookmarkNode* nodes_[2];

19 BOOL opened_[2];	19 BOOL opened_[2];

20 BOOL opened_new_foreground_tab;	20 BOOL opened_new_foreground_tab;

21 BOOL opened_new_window;	21 BOOL opened_new_window;

22 BOOL opened_off_the_record;	22 BOOL opened_off_the_record;

23 }	23 }

(...skipping 74 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
98 EXPECT_NE(c->opened_new_foreground_tab, NO);	98 EXPECT_NE(c->opened_new_foreground_tab, NO);

99	99

100 EXPECT_EQ(c->opened_new_window, NO);	100 EXPECT_EQ(c->opened_new_window, NO);

101 [c openAllBookmarksNewWindow:item];	101 [c openAllBookmarksNewWindow:item];

102 EXPECT_NE(c->opened_new_window, NO);	102 EXPECT_NE(c->opened_new_window, NO);

103	103

104 EXPECT_EQ(c->opened_off_the_record, NO);	104 EXPECT_EQ(c->opened_off_the_record, NO);

105 [c openAllBookmarksIncognitoWindow:item];	105 [c openAllBookmarksIncognitoWindow:item];

106 EXPECT_NE(c->opened_off_the_record, NO);	106 EXPECT_NE(c->opened_off_the_record, NO);

107 }	107 }

OLD	NEW