Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: chrome/browser/favicon/DEPS

Issue 284893003: Move bookmarks/core/... to bookmarks/... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing errors reported by presubmit Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # Favicon is being made into a Browser Component, so we have these 2 # Favicon is being made into a Browser Component, so we have these
3 # three basic rules followed by temporary exceptions. Please don't 3 # three basic rules followed by temporary exceptions. Please don't
4 # add to the list of exceptions! 4 # add to the list of exceptions!
5 "-chrome/browser", 5 "-chrome/browser",
6 "+chrome/browser/chrome_notification_types.h", 6 "+chrome/browser/chrome_notification_types.h",
7 "+chrome/browser/common", 7 "+chrome/browser/common",
8 "+chrome/browser/favicon", 8 "+chrome/browser/favicon",
9 9
10 # Permanently-allowed DEPS beyond the standard Browser 10 # Permanently-allowed DEPS beyond the standard Browser
11 # Components-like DEPS above go here. 11 # Components-like DEPS above go here.
12 "+chrome/browser/search/search.h", 12 "+chrome/browser/search/search.h",
13 "+components/favicon/core", 13 "+components/favicon/core",
14 "+third_party/skia/include/core/SkBitmap.h", 14 "+third_party/skia/include/core/SkBitmap.h",
15 15
16 # TODO(caitkp): Bring this list to zero. 16 # TODO(caitkp): Bring this list to zero.
17 # 17 #
18 # Do not add to the list of temporarily-allowed dependencies below, 18 # Do not add to the list of temporarily-allowed dependencies below,
19 # and please do not introduce more #includes of these files. 19 # and please do not introduce more #includes of these files.
20 "!chrome/browser/bookmarks/bookmark_model_factory.h", 20 "!chrome/browser/bookmarks/bookmark_model_factory.h",
21 "!chrome/browser/history/history_backend.h", 21 "!chrome/browser/history/history_backend.h",
22 "!chrome/browser/history/history_details.h", 22 "!chrome/browser/history/history_details.h",
23 "!chrome/browser/history/history_service.h", 23 "!chrome/browser/history/history_service.h",
24 "!chrome/browser/history/history_service_factory.h", 24 "!chrome/browser/history/history_service_factory.h",
25 "!chrome/browser/history/select_favicon_frames.h", 25 "!chrome/browser/history/select_favicon_frames.h",
26 "!chrome/browser/profiles/profile.h", 26 "!chrome/browser/profiles/profile.h",
27 "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h", 27 "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h",
28 "!components/bookmarks/core/browser/bookmark_model.h", 28 "!components/bookmarks/browser/bookmark_model.h",
29 # Do not add to the list of temporarily-allowed dependencies above, 29 # Do not add to the list of temporarily-allowed dependencies above,
30 # and please do not introduce more #includes of these files. 30 # and please do not introduce more #includes of these files.
31 ] 31 ]
32 32
33 specific_include_rules = { 33 specific_include_rules = {
34 # TODO(caitkp): Look into removing history/ dependencies. 34 # TODO(caitkp): Look into removing history/ dependencies.
35 'favicon_util\.(h|cc)': [ 35 'favicon_util\.(h|cc)': [
36 "-chrome", 36 "-chrome",
37 "-chrome/browser", 37 "-chrome/browser",
38 "+chrome/browser/favicon/favicon_util.h", 38 "+chrome/browser/favicon/favicon_util.h",
39 "+chrome/common/favicon/favicon_types.h", 39 "+chrome/common/favicon/favicon_types.h",
40 "+chrome/common/icon_messages.h", 40 "+chrome/common/icon_messages.h",
41 "!chrome/browser/history/history_types.h", 41 "!chrome/browser/history/history_types.h",
42 "!chrome/browser/history/select_favicon_frames.h", 42 "!chrome/browser/history/select_favicon_frames.h",
43 ] 43 ]
44 } 44 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/lazy_background_page_apitest.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698