chrome/browser/bookmarks/bookmark_stats.cc - Issue 284893003: Move bookmarks/core/... to bookmarks/...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/bookmarks/bookmark_stats.cc

Issue 284893003: Move bookmarks/core/... to bookmarks/... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing errors reported by presubmit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/bookmarks/bookmark_model_factory.cc ('k') | chrome/browser/bookmarks/chrome_bookmark_client.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/bookmarks/bookmark_stats.h"	5 #include "chrome/browser/bookmarks/bookmark_stats.h"

6	6

7 #include "base/metrics/histogram.h"	7 #include "base/metrics/histogram.h"

8 #include "components/bookmarks/core/browser/bookmark_model.h"	8 #include "components/bookmarks/browser/bookmark_model.h"

9 #include "content/public/browser/user_metrics.h"	9 #include "content/public/browser/user_metrics.h"

10	10

11 void RecordBookmarkLaunch(const BookmarkNode* node,	11 void RecordBookmarkLaunch(const BookmarkNode* node,

12 BookmarkLaunchLocation location) {	12 BookmarkLaunchLocation location) {

13 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR \|\|	13 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR \|\|

14 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) {	14 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) {

15 content::RecordAction(	15 content::RecordAction(

16 base::UserMetricsAction("ClickedBookmarkBarURLButton"));	16 base::UserMetricsAction("ClickedBookmarkBarURLButton"));

17 }	17 }

18 UMA_HISTOGRAM_ENUMERATION(	18 UMA_HISTOGRAM_ENUMERATION(

(...skipping 21 matching lines...) Expand all Loading...
40 }	40 }

41 }	41 }

42	42

43 void RecordBookmarkAppsPageOpen(BookmarkLaunchLocation location) {	43 void RecordBookmarkAppsPageOpen(BookmarkLaunchLocation location) {

44 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR \|\|	44 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR \|\|

45 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) {	45 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) {

46 content::RecordAction(	46 content::RecordAction(

47 base::UserMetricsAction("ClickedBookmarkBarAppsShortcutButton"));	47 base::UserMetricsAction("ClickedBookmarkBarAppsShortcutButton"));

48 }	48 }

49 }	49 }

OLD	NEW