Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 284893002: Include path to chromium's trunk should be before webrtc when building libjingle (otherwise e.g. we… (Closed)

Created:
6 years, 7 months ago by Mallinath (Gone from Chromium)
Modified:
6 years, 7 months ago
Reviewers:
hellner1
CC:
chromium-reviews
Visibility:
Public.

Description

Include path to chromium's trunk should be before webrtc when building libjingle (otherwise e.g. webrtc's base could be picked up when trunk/base is intended). Original CL https://codereview.chromium.org/279423006/ R=hellner@chromium.org TBR=hellner@chromium.org BUG=N/A Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/libjingle/libjingle.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hellner1
lgtm
6 years, 7 months ago (2014-05-13 16:54:20 UTC) #1
Mallinath (Gone from Chromium)
6 years, 7 months ago (2014-05-13 16:54:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r270129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698