Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 284883002: Fixed PinchViewport getting resized to empty size (Closed)

Created:
6 years, 7 months ago by bokan
Modified:
6 years, 7 months ago
Reviewers:
jam, kevers
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fixed PinchViewport getting resized to empty size. Looks like we forgot to save the visible viewport to the local member in RenderWidget. This was a problem when DisableAutoResize was called (such as by the BrowserPluginGuest, as in the bug) since it would pass the member variable along, resetting the pinch viewport to 0,0. Since the pinch viewport was recently made to clip its contents, this resulted in a blank screen. BUG=371061 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270331

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/render_widget.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bokan
PTAL
6 years, 7 months ago (2014-05-13 16:26:55 UTC) #1
kevers
lgtm
6 years, 7 months ago (2014-05-13 17:37:57 UTC) #2
jam
lgtm
6 years, 7 months ago (2014-05-13 21:06:07 UTC) #3
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 7 months ago (2014-05-13 22:22:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/284883002/20001
6 years, 7 months ago (2014-05-13 22:22:51 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 02:53:11 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 04:20:30 UTC) #7
Message was sent while issue was closed.
Change committed as 270331

Powered by Google App Engine
This is Rietveld 408576698