Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

Issue 2848823002: Add DCHECK() to check ApplyStyleCommand::DoApply() to work on non-null range (Closed)
Patch Set: 2017-04-28T14:02:57 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
index a3288860110bccfff73568fe04b820b379dece51..d707fdeb0f21659b9b57ad781db1e1a3865d928f 100644
--- a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
@@ -199,6 +199,8 @@ Position ApplyStyleCommand::EndPosition() {
}
void ApplyStyleCommand::DoApply(EditingState* editing_state) {
+ DCHECK(StartPosition().IsNotNull());
+ DCHECK(EndPosition().IsNotNull());
switch (property_level_) {
case kPropertyDefault: {
// Apply the block-centric properties of the style.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698