Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Unified Diff: tools/perf/page_sets/tough_video_cases.py

Issue 2848723003: Remove support for canvas element in tough_video_cases. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/tough_video_cases/video.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/tough_video_cases.py
diff --git a/tools/perf/page_sets/tough_video_cases.py b/tools/perf/page_sets/tough_video_cases.py
index bc7bb6f728afd98d33985d930948c1892bee633a..bc1004d6759f6f4c0486194d678cac3a36c75fa6 100644
--- a/tools/perf/page_sets/tough_video_cases.py
+++ b/tools/perf/page_sets/tough_video_cases.py
@@ -386,46 +386,6 @@ class Page36(ToughVideoCasesPage):
self.SeekBeforeAndAfterPlayhead(action_runner,
action_timeout_in_seconds=120)
-class Page37(ToughVideoCasesPage):
-
- def __init__(self, page_set):
- super(Page37, self).__init__(
- url=('file://tough_video_cases/video.html?src=crowd1080_vp9.webm&canvas='
- 'true'),
- page_set=page_set,
- tags=['vp9', 'video_only'])
-
- self.add_browser_metrics = True
-
- def RunPageInteractions(self, action_runner):
- self.PlayAction(action_runner)
-
-class Page38(ToughVideoCasesPage):
-
- def __init__(self, page_set):
- super(Page38, self).__init__(
- url='file://tough_video_cases/video.html?src=tulip2.mp4&canvas=true',
- page_set=page_set,
- tags=['h264', 'aac', 'audio_video'])
-
- self.add_browser_metrics = True
-
- def RunPageInteractions(self, action_runner):
- self.SeekBeforeAndAfterPlayhead(action_runner)
-
-class Page39(ToughVideoCasesPage):
-
- def __init__(self, page_set):
- super(Page39, self).__init__(
- url=('file://tough_video_cases/video.html?src=garden2_10s.webm&canvas='
- 'true'),
- page_set=page_set,
- tags=['is_4k', 'vp8', 'vorbis', 'audio_video'])
-
- self.add_browser_metrics = True
-
- def RunPageInteractions(self, action_runner):
- self.PlayAction(action_runner)
class ToughVideoCasesPageSet(story.StorySet):
"""
@@ -435,8 +395,8 @@ class ToughVideoCasesPageSet(story.StorySet):
def __init__(self):
super(ToughVideoCasesPageSet, self).__init__(
cloud_storage_bucket=story.PARTNER_BUCKET)
- # TODO(crouleau): Pages 36 and 38 are in ToughVideoCasesPageSet even though
- # they both report seek time instead of time_to_play.
+ # TODO(crouleau): Page 36 is in ToughVideoCasesPageSet even though
+ # it both reports seek time instead of time_to_play.
# This may be a non-issue because we plan to merge these two page sets back
# together and use tags to allow teams to filter which pages they want.
@@ -455,9 +415,6 @@ class ToughVideoCasesPageSet(story.StorySet):
self.AddStory(Page32(self))
self.AddStory(Page34(self))
self.AddStory(Page36(self))
- self.AddStory(Page37(self))
- self.AddStory(Page38(self))
- self.AddStory(Page39(self))
class ToughVideoCasesExtraPageSet(story.StorySet):
« no previous file with comments | « no previous file | tools/perf/page_sets/tough_video_cases/video.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698