chrome/browser/android/banners/app_banner_infobar_delegate_android.cc - Issue 2848703005: Fix appinstalled event firing when user opens a WebAPK from banner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Issue 2848703005: Fix appinstalled event firing when user opens a WebAPK from banner. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/banners/app_banner_infobar_delegate_android.h ('K') | « chrome/browser/android/banners/app_banner_infobar_delegate_android.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

index c0b69b8270aa85d7f07b074489deaec14d67ba4f..5d8f0190b130def904f7e8c3ff335a448745be82 100644

--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

@@ -303,11 +303,10 @@ bool AppBannerInfoBarDelegateAndroid::AcceptWebApk(

JNIEnv* env = base::android::AttachCurrentThread();

// If the WebAPK is installed and the "Open" button is clicked, open the

- // WebAPK.

+ // WebAPK. Do not send a BannerAccepted message.

if (install_state_ == INSTALLED) {

Java_AppBannerInfoBarDelegateAndroid_openWebApk(env, java_delegate_);

webapk::TrackUserAction(webapk::USER_ACTION_INSTALLED_OPEN);

- SendBannerAccepted();

return true;

}