chrome/browser/resources/settings/internet_page/internet_detail_page.js - Issue 2848683003: MD Settings: Add settings-internet-config (WiFi only, no certs)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2848683003: MD Settings: Add settings-internet-config (WiFi only, no certs) (Closed)

Patch Set: . Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/internet_page/internet_config.js ('K') | « chrome/browser/resources/settings/internet_page/internet_detail_page.html ('k') | chrome/browser/resources/settings/internet_page/internet_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js

diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

index 395090654201415ed3270b126efc57307a806a66..f696cb5b995f194d279f4e151180294955f1abd1 100644

--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js

+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

@@ -602,7 +602,10 @@ Polymer({

/** @private */

onConfigureTap_: function() {

- chrome.send('configureNetwork', [this.guid]);

+ if (loadTimeData.getBoolean('networkSettingsConfig'))

+ this.fire('show-config', this.networkProperties);

+ else

+ chrome.send('configureNetwork', [this.guid]);

michaelpg 2017/05/18 21:14:23 nit: add a "TODO(stevenjb): remove" in the C++ han

stevenjb 2017/05/19 23:35:34 That's kind of automatic with the switch handling;

/** @private */