Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: extensions/common/api/networking_private.idl

Issue 2848683003: MD Settings: Add settings-internet-config (WiFi only, no certs) (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chromeos/chromeos_switches.h ('K') | « chromeos/chromeos_switches.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/api/networking_private.idl
diff --git a/extensions/common/api/networking_private.idl b/extensions/common/api/networking_private.idl
index a6a35571024797fc5a05334dc20f3da0fec32628..38dec6c1eda7020c12d3b140897f07ffd71f1b88 100644
--- a/extensions/common/api/networking_private.idl
+++ b/extensions/common/api/networking_private.idl
@@ -21,11 +21,7 @@
// "Config" properties describe just the ONC properties that can be configured
// through this API. NOTE: Not all configuration properties are exposed at this
// time, only those currently required by the Chrome Settings UI.
-// TODO(stevenjb): Provide all configuration properties and types,
-// crbug.com/380937.
// <br><br>
-// TODO(stevenjb/pneubeck): Merge the ONC documentation with this document and
-// use it as the ONC specification.
stevenjb 2017/05/02 00:17:45 revert
namespace networkingPrivate {
enum ActivationStateType {
@@ -836,9 +832,7 @@ namespace networkingPrivate {
callback VoidCallback = void();
callback BooleanCallback = void(boolean result);
callback StringCallback = void(DOMString result);
- // TODO(stevenjb): Use NetworkProperties for |result| once defined.
callback GetPropertiesCallback = void(NetworkProperties result);
- // TODO(stevenjb): Use ManagedNetworkProperties for |result| once defined.
callback GetManagedPropertiesCallback = void(ManagedProperties result);
callback GetStatePropertiesCallback = void(NetworkStateProperties result);
callback GetNetworksCallback = void(NetworkStateProperties[] result);
« chromeos/chromeos_switches.h ('K') | « chromeos/chromeos_switches.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698