Add a DevTools command to create an isolated world for a given frame

third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 41 matching lines @@
 class PLATFORM_EXPORT DOMWrapperWorld : public RefCounted<DOMWrapperWorld> {
  public:
   // Per-thread global identifiers for DOMWrapperWorld.
   enum WorldId {
     kInvalidWorldId = -1,
     kMainWorldId = 0,
 
     // Embedder isolated worlds can use IDs in [1, 1<<29).
     kEmbedderWorldIdLimit = (1 << 29),
     kDocumentXMLTreeViewerWorldId,
+    kDevToolsFirstIsolatedWorldId,
+    kDevToolsLastIsolatedWorldId = kDevToolsFirstIsolatedWorldId + 100,
     kIsolatedWorldIdLimit,
 
     // Other worlds can use IDs after this. Don't manually pick up an ID from
     // this range. generateWorldIdForType() picks it up on behalf of you.
     kUnspecifiedWorldIdStart,
   };
 
   enum class WorldType {
     kMain,
     kIsolated,
@@ skipping 62 matching lines @@
   DOMDataStore& DomDataStore() const { return *dom_data_store_; }
 
   template <typename T>
   void RegisterDOMObjectHolder(v8::Isolate* isolate,
                                T* object,
                                v8::Local<v8::Value> wrapper) {
     RegisterDOMObjectHolderInternal(
         DOMObjectHolder<T>::Create(isolate, object, wrapper));
   }
 
+  // Returns an identifier for a given world type. This must not be called for
+  // WorldType::IsolatedWorld because an identifier for the world is given from
+  // out of DOMWrapperWorld.
+  static int GenerateWorldIdForType(WorldType);
+
  private:
   class DOMObjectHolderBase {
     USING_FAST_MALLOC(DOMObjectHolderBase);
 
    public:
     DOMObjectHolderBase(v8::Isolate* isolate, v8::Local<v8::Value> wrapper)
         : wrapper_(isolate, wrapper), world_(nullptr) {}
     virtual ~DOMObjectHolderBase() {}
 
     DOMWrapperWorld* World() const { return world_; }
@@ skipping 26 matching lines @@
 
   DOMWrapperWorld(v8::Isolate*, WorldType, int world_id);
 
   static void WeakCallbackForDOMObjectHolder(
       const v8::WeakCallbackInfo<DOMObjectHolderBase>&);
   void RegisterDOMObjectHolderInternal(std::unique_ptr<DOMObjectHolderBase>);
   void UnregisterDOMObjectHolder(DOMObjectHolderBase*);
 
   static unsigned number_of_non_main_worlds_in_main_thread_;
 
-  // Returns an identifier for a given world type. This must not be called for
-  // WorldType::IsolatedWorld because an identifier for the world is given from
-  // out of DOMWrapperWorld.
-  static int GenerateWorldIdForType(WorldType);
+  // Returns an id in the range
+  // [kDevToolsFirstIsolatedWorldId, kDevToolsLastIsolatedWorldId] or
+  // kInvalidWorldId if that range has been exhausted.
+  static int GetNextDevToolsIsolatedWorldId();

[pfeldman, 2017/05/08 20:27:12]

I would go all the way and introduce WorldType for DevTools instead. It is
called Inspector in the blink source base btw.

[alex clarke (OOO till 29th), 2017/05/09 08:19:06]

Done. I've also renamed all the DevTools references in this patch to Inspector.

 
   // Dissociates all wrappers in all worlds associated with |script_wrappable|.
   //
   // Do not use this function except for DOMWindow.  Only DOMWindow needs to
   // dissociate wrappers from the ScriptWrappable because of the following two
   // reasons.
   //
   // Reason 1) Case of the main world
   // A DOMWindow may be collected by Blink GC *before* V8 GC collects the
   // wrapper because the wrapper object associated with a DOMWindow is a global
@@ skipping 14 matching lines @@
 
   const WorldType world_type_;
   const int world_id_;
   std::unique_ptr<DOMDataStore> dom_data_store_;
   HashSet<std::unique_ptr<DOMObjectHolderBase>> dom_object_holders_;
 };
 
 }  // namespace blink
 
 #endif  // DOMWrapperWorld_h