Add a DevTools command to create an isolated world for a given frame

third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 41 matching lines @@
 class PLATFORM_EXPORT DOMWrapperWorld : public RefCounted<DOMWrapperWorld> {
  public:
   // Per-thread global identifiers for DOMWrapperWorld.
   enum WorldId {
     kInvalidWorldId = -1,
     kMainWorldId = 0,
 
     // Embedder isolated worlds can use IDs in [1, 1<<29).
     kEmbedderWorldIdLimit = (1 << 29),
     kDocumentXMLTreeViewerWorldId,
+    kDevToolsFirstIsolatedWorldId,
+    kDevToolsLastIsolatedWorldId = kDevToolsFirstIsolatedWorldId + 10,

[pfeldman, 2017/05/05 15:40:24]

10 worlds should be enough for everyone? :) Can we bump it to a 100?

[caseq, 2017/05/05 16:36:02]

+1, I can imagine an easy scenario for leaking these ids when client repeatedly
re-connects, considering we can't release worlds.

[alex clarke (OOO till 29th), 2017/05/05 19:29:44]

Done.

[alex clarke (OOO till 29th), 2017/05/05 19:29:44]

Done.

     kIsolatedWorldIdLimit,
 
     // Other worlds can use IDs after this. Don't manually pick up an ID from
     // this range. generateWorldIdForType() picks it up on behalf of you.

[caseq, 2017/05/05 16:36:02]

I just noticed this. Should we just use generateWorldIdForType()?

[alex clarke (OOO till 29th), 2017/05/05 19:29:44]

I suppose we could.  We'll need to either make it public or make
DOMWrapperWorld::Create work with isolated worlds (it needs to be able to fail
rather just DCHECK when we run out of IDs).  For now I'm going to suggest making
it public.  WDYT?

     kUnspecifiedWorldIdStart,
   };
 
   enum class WorldType {
     kMain,
     kIsolated,
     kGarbageCollector,
     kRegExp,
     kTesting,
     kWorker,
@@ skipping 58 matching lines @@
   DOMDataStore& DomDataStore() const { return *dom_data_store_; }
 
   template <typename T>
   void RegisterDOMObjectHolder(v8::Isolate* isolate,
                                T* object,
                                v8::Local<v8::Value> wrapper) {
     RegisterDOMObjectHolderInternal(
         DOMObjectHolder<T>::Create(isolate, object, wrapper));
   }
 
+  // Returns an id in the range
+  // [kDevToolsFirstIsolatedWorldId, kDevToolsLastIsolatedWorldId] or
+  // kInvalidWorldId if that range has been exhausted.
+  static int GetNextDevToolsIsolatedWorldId();
+
  private:
   class DOMObjectHolderBase {
     USING_FAST_MALLOC(DOMObjectHolderBase);
 
    public:
     DOMObjectHolderBase(v8::Isolate* isolate, v8::Local<v8::Value> wrapper)
         : wrapper_(isolate, wrapper), world_(nullptr) {}
     virtual ~DOMObjectHolderBase() {}
 
     DOMWrapperWorld* World() const { return world_; }
@@ skipping 64 matching lines @@
 
   const WorldType world_type_;
   const int world_id_;
   std::unique_ptr<DOMDataStore> dom_data_store_;
   HashSet<std::unique_ptr<DOMObjectHolderBase>> dom_object_holders_;
 };
 
 }  // namespace blink
 
 #endif  // DOMWrapperWorld_h