Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

Issue 2848643003: Fix `selectionOffset` testing. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
index 1acc5b94199046a676f05d8a433e277ef5b2cc5e..9f75662be73aae9b4275b211d549f125820664db 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
@@ -135,11 +135,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
expect(cs.relevance, equals(relevance), reason: completion);
}
expect(cs.importUri, importUri);
- //TODO(pq): fix offset bug for trailing commas
- // and replace w/ expect(cs.selectionOffset, equals(selectionOffset ?? completion.length));
- if (selectionOffset != null) {
- expect(cs.selectionOffset, equals(selectionOffset));
- }
+ expect(cs.selectionOffset, equals(selectionOffset ?? completion.length));
expect(cs.selectionLength, equals(0));
expect(cs.isDeprecated, equals(isDeprecated));
expect(cs.isPotential, equals(isPotential));
« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698