Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1732)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 2848633003: Rename FLAGS_quic_enable_version_39 to FLAGS_quic_reloadable_flag_quic_enable_version_39. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/end_to_end_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index dd6e3c55080708e2b8108a5ddd3a37e978073e7c..d4bb849ae76589c74b683a40ea9b79f3c2378b97 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -531,7 +531,7 @@ TEST_F(QuicDispatcherTest, SupportedVersionsChangeInFlight) {
static_assert(arraysize(kSupportedQuicVersions) == 5u,
"Supported versions out of sync");
FLAGS_quic_reloadable_flag_quic_enable_version_38 = true;
- FLAGS_quic_enable_version_39 = true;
+ FLAGS_quic_reloadable_flag_quic_enable_version_39 = true;
QuicSocketAddress client_address(QuicIpAddress::Loopback4(), 1);
server_address_ = QuicSocketAddress(QuicIpAddress::Any4(), 5);
QuicConnectionId connection_id = 1;
@@ -571,7 +571,7 @@ TEST_F(QuicDispatcherTest, SupportedVersionsChangeInFlight) {
PACKET_6BYTE_PACKET_NUMBER, 1);
// Turn off version 39.
- FLAGS_quic_enable_version_39 = false;
+ FLAGS_quic_reloadable_flag_quic_enable_version_39 = false;
++connection_id;
EXPECT_CALL(*dispatcher_, CreateQuicSession(connection_id, client_address))
.Times(0);
@@ -580,7 +580,7 @@ TEST_F(QuicDispatcherTest, SupportedVersionsChangeInFlight) {
PACKET_6BYTE_PACKET_NUMBER, 1);
// Turn on version 39.
- FLAGS_quic_enable_version_39 = true;
+ FLAGS_quic_reloadable_flag_quic_enable_version_39 = true;
++connection_id;
EXPECT_CALL(*dispatcher_, CreateQuicSession(connection_id, client_address))
.WillOnce(testing::Return(CreateSession(
« no previous file with comments | « net/tools/quic/end_to_end_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698