Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4277)

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 2848613002: Disable CreateNewFolder/FileManagerBrowserTest because flaky. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
index 0e9d776454dba7b75b9ef9d8c3e684f482494b38..711fc5d42564996ac55eaa4e8db5ace40588e51b 100644
--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
@@ -129,22 +129,15 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
TestParameter(NOT_IN_GUEST_MODE, "imageOpenDownloads"),
TestParameter(NOT_IN_GUEST_MODE, "imageOpenDrive")));
-#if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
-#define MAYBE_CreateNewFolder DISABLED_CreateNewFolder
-#else
-#define MAYBE_CreateNewFolder CreateNewFolder
-#endif
+// Flaky: crbug.com/715963
WRAPPED_INSTANTIATE_TEST_CASE_P(
- MAYBE_CreateNewFolder,
+ DISABLED_CreateNewFolder,
FileManagerBrowserTest,
- ::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
- "createNewFolderAfterSelectFile"),
- TestParameter(IN_GUEST_MODE,
- "createNewFolderDownloads"),
- TestParameter(NOT_IN_GUEST_MODE,
- "createNewFolderDownloads"),
- TestParameter(NOT_IN_GUEST_MODE,
- "createNewFolderDrive")));
+ ::testing::Values(
+ TestParameter(NOT_IN_GUEST_MODE, "createNewFolderAfterSelectFile"),
+ TestParameter(IN_GUEST_MODE, "createNewFolderDownloads"),
+ TestParameter(NOT_IN_GUEST_MODE, "createNewFolderDownloads"),
+ TestParameter(NOT_IN_GUEST_MODE, "createNewFolderDrive")));
// Fails on official build. http://crbug.com/429294
#if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698