Fix HDCP in mirror mode.

ash/display/display_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_DISPLAY_DISPLAY_MANAGER_H_
 #define ASH_DISPLAY_DISPLAY_MANAGER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 235 matching lines @@
 
   // Used to emulate display change when run in a desktop environment instead
   // of on a device.
   void AddRemoveDisplay();
   void ToggleDisplayScaleFactor();
 
   // SoftwareMirroringController override:
 #if defined(OS_CHROMEOS)
   virtual void SetSoftwareMirroring(bool enabled) OVERRIDE;
 #endif
-  bool software_mirroring_enabled() const {
+  virtual bool software_mirroring_enabled() const {

[Daniel Erat, 2014/05/15 14:04:25]

making an accessor virtual seems strange...

[kcwu1, 2014/05/15 15:02:42]

If not, how do you suggest to expose this method for
SoftwareMirroringController?

[dnicoara, 2014/05/15 19:38:48]

I think the confusion comes from the fact that the unix_hacker_style should not
be used for virtual functions (as per coding guidelines). Or maybe because
OVERRIDE is missing (so it isn't obvious that this function is implementing the
interface).

Also, should it be in the #ifdef above?

[kcwu, 2014/05/16 04:36:39]

Done.
It should not be in #ifdef because it is also used by this class itself.

     return second_display_mode_ == MIRRORING;
   };
 
   bool virtual_keyboard_root_window_enabled() const {
     return second_display_mode_ == VIRTUAL_KEYBOARD;
   };
 
   // Sets/gets second display mode.
   void SetSecondDisplayMode(SecondDisplayMode mode);
   SecondDisplayMode second_display_mode() const {
@@ skipping 93 matching lines @@
   SecondDisplayMode second_display_mode_;
   int64 mirrored_display_id_;
   gfx::Display non_desktop_display_;
 
   DISALLOW_COPY_AND_ASSIGN(DisplayManager);
 };
 
 }  // namespace ash
 
 #endif  // ASH_DISPLAY_DISPLAY_MANAGER_H_