Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2848513002: Introduce the abstract class WebViewBase, to decouple WebViewImpl. (Closed)
Patch Set: Add comments to WebViewBase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 // Pass the WebViewImpl's self-reference to the caller. 277 // Pass the WebViewImpl's self-reference to the caller.
278 return WebViewImpl::Create(client, visibility_state); 278 return WebViewImpl::Create(client, visibility_state);
279 } 279 }
280 280
281 WebViewImpl* WebViewImpl::Create(WebViewClient* client, 281 WebViewImpl* WebViewImpl::Create(WebViewClient* client,
282 WebPageVisibilityState visibility_state) { 282 WebPageVisibilityState visibility_state) {
283 // Pass the WebViewImpl's self-reference to the caller. 283 // Pass the WebViewImpl's self-reference to the caller.
284 return AdoptRef(new WebViewImpl(client, visibility_state)).LeakRef(); 284 return AdoptRef(new WebViewImpl(client, visibility_state)).LeakRef();
285 } 285 }
286 286
287 const WebInputEvent* WebViewBase::CurrentInputEvent() {
288 return WebViewImpl::CurrentInputEvent();
289 }
290
287 void WebView::SetUseExternalPopupMenus(bool use_external_popup_menus) { 291 void WebView::SetUseExternalPopupMenus(bool use_external_popup_menus) {
288 g_should_use_external_popup_menus = use_external_popup_menus; 292 g_should_use_external_popup_menus = use_external_popup_menus;
289 } 293 }
290 294
291 void WebView::UpdateVisitedLinkState(unsigned long long link_hash) { 295 void WebView::UpdateVisitedLinkState(unsigned long long link_hash) {
292 Page::VisitedStateChanged(link_hash); 296 Page::VisitedStateChanged(link_hash);
293 } 297 }
294 298
295 void WebView::ResetVisitedLinkState(bool invalidate_visited_link_hashes) { 299 void WebView::ResetVisitedLinkState(bool invalidate_visited_link_hashes) {
296 Page::AllVisitedStateChanged(invalidate_visited_link_hashes); 300 Page::AllVisitedStateChanged(invalidate_visited_link_hashes);
(...skipping 3860 matching lines...) Expand 10 before | Expand all | Expand 10 after
4157 if (focused_frame->LocalFrameRoot() != MainFrameImpl()->GetFrame()) 4161 if (focused_frame->LocalFrameRoot() != MainFrameImpl()->GetFrame())
4158 return nullptr; 4162 return nullptr;
4159 return focused_frame; 4163 return focused_frame;
4160 } 4164 }
4161 4165
4162 LocalFrame* WebViewImpl::FocusedLocalFrameAvailableForIme() const { 4166 LocalFrame* WebViewImpl::FocusedLocalFrameAvailableForIme() const {
4163 return ime_accept_events_ ? FocusedLocalFrameInWidget() : nullptr; 4167 return ime_accept_events_ ? FocusedLocalFrameInWidget() : nullptr;
4164 } 4168 }
4165 4169
4166 } // namespace blink 4170 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698