Reduce/Remove URLRequest dependencies from AppCacheRequestHandler

content/browser/appcache/appcache_url_loader.h

Index: content/browser/appcache/appcache_url_loader.h
diff --git a/content/browser/appcache/appcache_url_loader.h b/content/browser/appcache/appcache_url_loader.h
new file mode 100644
index 0000000000000000000000000000000000000000..8613d81dcb6ceedc2a342698a8b26cebae8edb27
--- /dev/null
+++ b/content/browser/appcache/appcache_url_loader.h
@@ -0,0 +1,52 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_H_
+#define CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_H_
+
+#include "content/browser/appcache/appcache_request.h"
+#include "content/common/resource_request.h"
+
+namespace content {
+
+// AppCacheRequest wrapper for the ResourceRequest class.

[kinuko, 2017/05/03 01:28:21]

... for the cases that uses URLLoader.

?

Could you also change the class name in the description?

[ananta, 2017/05/03 01:34:00]

Done.

[ananta, 2017/05/03 01:34:00]

Done.

+class CONTENT_EXPORT AppCacheURLLoader : public AppCacheRequest {
+ public:
+  // Factory function to create an instance of the AppCacheResourceRequest
+  // class.
+  static AppCacheURLLoader* Create(const ResourceRequest& request);
+
+  // AppCacheRequest overrides.
+  // TODO(ananta)
+  // Add support to the GetURL() call to return the updated URL while following
+  // a chain of redirects.
+  const GURL& GetURL() const override;
+  const std::string& GetMethod() const override;
+  const GURL& GetFirstPartyForCookies() const override;
+  const GURL GetReferrer() const override;
+  // TODO(ananta)
+  // ResourceRequest only identifies the request unlike URLRequest which
+  // contains response information as well. We need the following methods to
+  // work for AppCache. Look into this.
+  bool IsSuccess() const override;
+  bool IsCancelled() const override;
+  bool IsError() const override;
+  int GetResponseCode() const override;
+  std::string GetResponseHeaderByName(const std::string& name) const override;
+
+  ResourceRequest* GetResourceRequest() override;
+
+ protected:
+  AppCacheURLLoader(const ResourceRequest& request);

[kinuko, 2017/05/03 01:28:21]

nit: explicit

[ananta, 2017/05/03 01:34:00]

Done.

[ananta, 2017/05/03 01:34:01]

Done.

+  ~AppCacheURLLoader() override;
+
+ private:
+  ResourceRequest request_;
+
+  DISALLOW_COPY_AND_ASSIGN(AppCacheURLLoader);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_H_