Reduce/Remove URLRequest dependencies from AppCacheRequestHandler

content/browser/appcache/appcache_url_loader.h

+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_H_
+#define CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_H_
+
+#include "content/browser/appcache/appcache_request.h"
+#include "content/common/resource_request.h"
+
+namespace content {
+
+// AppCacheRequest wrapper for the ResourceRequest class for users of
+// URLLoader.
+class CONTENT_EXPORT AppCacheURLLoader : public AppCacheRequest {

[michaeln, 2017/05/03 02:32:12]

Sorry for the naming nit, but this isn't the 'loader' either? This should be
some kind of 'request'.

maybe call this one AppCacheLoaderRequest and the other is AppCacheURLReqeust

// some auto-chromium-class-name-generating :)
AppCacheLoaderRequest (this one might be ok)
AppCacheURLLoadRequest
AppCacheResourceLoaderRequest
AppCacheLoadRequest

and the other new class job'ish class could be AppCacheLoaderJob (akin to
AppCacheURLRequestJob)

[jam, 2017/05/03 03:54:45]

My suggestion was because one subclass is implemented with net::URLRequest and
it's named AppCacheURLRequest, while the other one is implemented with
mojom::URLLoader so AppCacheURLLoader seemed the consistent choice.

+ public:
+  // Factory function to create an instance of the AppCacheResourceRequest
+  // class.
+  static AppCacheURLLoader* Create(const ResourceRequest& request);
+
+  // AppCacheRequest overrides.
+  // TODO(ananta)
+  // Add support to the GetURL() call to return the updated URL while following
+  // a chain of redirects.
+  const GURL& GetURL() const override;
+  const std::string& GetMethod() const override;
+  const GURL& GetFirstPartyForCookies() const override;
+  const GURL GetReferrer() const override;
+  // TODO(ananta)
+  // ResourceRequest only identifies the request unlike URLRequest which
+  // contains response information as well. We need the following methods to
+  // work for AppCache. Look into this.
+  bool IsSuccess() const override;
+  bool IsCancelled() const override;
+  bool IsError() const override;
+  int GetResponseCode() const override;
+  std::string GetResponseHeaderByName(const std::string& name) const override;
+
+  ResourceRequest* GetResourceRequest() override;
+
+ protected:
+  explicit AppCacheURLLoader(const ResourceRequest& request);
+  ~AppCacheURLLoader() override;
+
+ private:
+  ResourceRequest request_;
+
+  DISALLOW_COPY_AND_ASSIGN(AppCacheURLLoader);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_H_