Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/people_page/setup_pin_dialog.js

Issue 2848483002: md settings: Move setup pin error message. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/settings/people_page/setup_pin_dialog.html ('K') | « chrome/browser/resources/settings/people_page/setup_pin_dialog.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/setup_pin_dialog.js
diff --git a/chrome/browser/resources/settings/people_page/setup_pin_dialog.js b/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
index 428b5ae7f98093be157898f23b5dfa1c5939158d..bd4f1e7514b544c6468ca3b786c5148cc0d6f6c4 100644
--- a/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
+++ b/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
@@ -290,10 +290,11 @@ Polymer({
/**
* @private
* @param {string} problemMessage
+ * @param {string} problemClass
* @return {boolean}
*/
- hasProblem_: function(problemMessage) {
- return !!problemMessage;
+ hasError_: function(problemMessage, problemClass) {
+ return !!problemMessage && problemClass == ProblemType.ERROR;
},
/**
« chrome/browser/resources/settings/people_page/setup_pin_dialog.html ('K') | « chrome/browser/resources/settings/people_page/setup_pin_dialog.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698