Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4316)

Unified Diff: chrome/browser/resources/settings/people_page/setup_pin_dialog.html

Issue 2848483002: md settings: Move setup pin error message. (Closed)
Patch Set: Fix patch set 2 errors. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/setup_pin_dialog.html
diff --git a/chrome/browser/resources/settings/people_page/setup_pin_dialog.html b/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
index 040c5cbc932ba25c5920f9ee7f196d66a5b87ddf..d21c0a2c52465686238babbf8de61efbf6fcc7b8 100644
--- a/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
+++ b/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
@@ -11,14 +11,6 @@
<dom-module id="settings-setup-pin-dialog">
<template>
<style include="settings-shared">
- .warning {
- color: var(--paper-grey-700);
- }
-
- .warning > iron-icon {
- --iron-icon-fill-color: var(--paper-grey-700);
- }
-
.error {
color: var(--paper-red-500);
}
@@ -27,27 +19,38 @@
--iron-icon-fill-color: var(--paper-red-500);
}
+ .warning {
+ color: var(--paper-grey-700);
+ }
+
+ .warning > iron-icon {
+ --iron-icon-fill-color: var(--paper-grey-700);
+ }
+
#pinKeyboardDiv {
justify-content: center;
}
+
+ #problemMessage {
+ font-size: 10px;
+ }
</style>
<dialog is="cr-dialog" id="dialog" on-close="close"
close-text="$i18n{close}">
<div class="title">[[getTitleMessage_(isConfirmStep_)]]</div>
<div class="body">
- <!-- Warning/error; only shown if title is hidden. Id is needed for
- tests. -->
- <div id="problemDiv" class$="[[problemClass_]] settings-box first"
- hidden$="[[!hasProblem_(problemMessage_)]]">
- <iron-icon icon="settings:warning"></iron-icon>
- <span class="middle">[[problemMessage_]]</span>
- </div>
-
<!-- Pin keyboard -->
<div id="pinKeyboardDiv" class="settings-box continuation">
<pin-keyboard id="pinKeyboard" on-pin-change="onPinChange_"
- on-submit="onPinSubmit_" value="{{pinKeyboardValue_}}">
+ on-submit="onPinSubmit_" value="{{pinKeyboardValue_}}"
+ has-error$="[[hasError_(problemMessage_, problemClass_)]]">
+ <!-- Warning/error; only shown if title is hidden. -->
+ <div id="problemDiv" class$="[[problemClass_]]"
+ hidden$="[[!problemMessage_]]" problem>
+ <iron-icon icon="settings:error-outline"></iron-icon>
+ <span id="problemMessage">[[problemMessage_]]</span>
+ </div>
</pin-keyboard>
</div>
« no previous file with comments | « chrome/browser/resources/settings/icons.html ('k') | chrome/browser/resources/settings/people_page/setup_pin_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698