dynamic context menu resizing

chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextmenu;
 
 import android.content.Context;
 import android.support.v4.view.ViewPager;
 import android.util.AttributeSet;
 import android.view.View;
 
 import org.chromium.chrome.R;
 
 /**
  * When there is more than one view for the context menu to display, it wraps the display in a view
  * pager.
  */
 public class TabularContextMenuViewPager extends ViewPager {
+
     public TabularContextMenuViewPager(Context context) {
         super(context);
     }
 
     public TabularContextMenuViewPager(Context context, AttributeSet attrs) {
         super(context, attrs);
     }
 
     /**
      * Used to show the full ViewPager dialog. Without this the dialog would have no height or
      * width.
      */
     @Override
     protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
-        int maxHeight = 0;
+        int menuHeight = 0;
         int tabHeight = 0;
+        //getCurrentItem() does not take into account the tab layout unlike getChildCount()

[gone, 2017/04/27 18:14:14]

space after //
end with a period

https://google.github.io/styleguide/javaguide.html#s4.8.6-comments
https://google.github.io/styleguide/cppguide.html#Punctuation,_Spelling_and_G...

Why is the TabLayout a child of the ViewPager instead of the parent?  AIUI a
ViewPager is supposed to just flip between two views.  It shouldn't have any
dangly Views that aren't flipped between because you end up in situations like
this.

[gone, 2017/05/02 17:15:41]

Welp, that's required because that's how ViewPager works for some weird reason.
https://developer.android.com/reference/android/support/design/widget/TabLayo...

[Daniel Park, 2017/05/02 17:32:24]

Done.

+        int currentItemsIndex = getCurrentItem() + 1;
+
         for (int i = 0; i < getChildCount(); i++) {
             View child = getChildAt(i);
             child.measure(widthMeasureSpec,
-                    MeasureSpec.makeMeasureSpec(maxHeight, MeasureSpec.UNSPECIFIED));
+                    MeasureSpec.makeMeasureSpec(menuHeight, MeasureSpec.UNSPECIFIED));

[gone, 2017/04/27 18:14:14]

makeMeasureSpec(0, MeasureSpec.UNSPECIFIED).  Setting this to menuHeight makes
no sense because it just tells the child to measure itself without caring about
height (and it's 0 to start with anyway).

[Daniel Park, 2017/05/02 17:32:24]

Done.

             int measuredHeight = child.getMeasuredHeight();
-

[gone, 2017/04/27 18:14:14]

Put this line back.  It' a comment sandwich otherwise.

[Daniel Park, 2017/05/02 17:57:58]

Done.

             // The ViewPager also considers the tab layout one of its children, and needs to be
             // treated separately from getting the largest height.
             if (child.getId() == R.id.tab_layout && child.getVisibility() != GONE) {
                 tabHeight = measuredHeight;
-            } else {
-                maxHeight = Math.max(maxHeight, child.getMeasuredHeight());
+            } else if (i == currentItemsIndex) {
+                menuHeight = child.getMeasuredHeight();
+                break;
             }
         }
-        maxHeight += tabHeight;
-        heightMeasureSpec = MeasureSpec.makeMeasureSpec(maxHeight, MeasureSpec.EXACTLY);
+        menuHeight += tabHeight;

[gone, 2017/04/27 18:14:14]

int fullHeight = menuHeight + tabHeight?

[Daniel Park, 2017/05/02 17:32:24]

Done.

+
+        heightMeasureSpec = MeasureSpec.makeMeasureSpec(menuHeight, MeasureSpec.EXACTLY);
         super.onMeasure(widthMeasureSpec, heightMeasureSpec);
     }
+
 }