Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: recipe_engine/autoroll.py

Issue 2848443003: [recipes.py] add missing helpstrings, merge test subcommands into main parser. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | recipe_engine/bundle.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_engine/autoroll.py
diff --git a/recipe_engine/autoroll.py b/recipe_engine/autoroll.py
index b733a9b5f982b32aaf4305dc428d2bbc1682e0c8..bb65b11207d85aca2f4fd563d2a89cc0d4d47101 100644
--- a/recipe_engine/autoroll.py
+++ b/recipe_engine/autoroll.py
@@ -268,20 +268,23 @@ def test_rolls(repo_cfg_block, config_file, context, package_spec,
def add_subparser(parser):
+ helpstr = 'Roll dependencies of a recipe package forward.'
autoroll_p = parser.add_parser(
- 'autoroll',
- help='Roll dependencies of a recipe package forward (implies fetch)')
+ 'autoroll', help=helpstr, description=helpstr)
autoroll_p.add_argument(
- '--output-json',
- type=os.path.abspath,
- help='A json file to output information about the roll to.')
+ '--output-json',
+ type=os.path.abspath,
+ help='A json file to output information about the roll to.')
autoroll_p.add_argument(
- '--verbose-json',
- action='store_true',
- help=('Emit even more data in the output-json file. '
- 'Requires --output-json.'))
+ '--verbose-json',
+ action='store_true',
+ help=('Emit even more data in the output-json file. '
+ 'Requires --output-json.'))
def postprocess_func(parser, args):
+ if args.no_fetch:
+ parser.error('autoroll with --no-fetch does not make sense.')
+
if args.verbose_json and not args.output_json:
parser.error('--verbose-json passed without --output-json')
« no previous file with comments | « no previous file | recipe_engine/bundle.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698