Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 284843007: Remove +x bit from installer/linux/sysroot_scripts/sysroot-creator.sh (Closed)

Created:
6 years, 7 months ago by Sam Clegg
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang, piman
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Remove +x bit from installer/linux/sysroot_scripts/sysroot-creator.sh This was causing checkperms.py to fail. R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A chrome/installer/linux/sysroot_scripts/sysroot-creator.sh View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sam Clegg
6 years, 7 months ago (2014-05-14 00:30:48 UTC) #1
piman
lgtm
6 years, 7 months ago (2014-05-14 00:31:05 UTC) #2
piman
On 2014/05/14 00:31:05, piman wrote: > lgtm (feel free to TBR to fix the tree.)
6 years, 7 months ago (2014-05-14 00:31:24 UTC) #3
Sam Clegg
Do you know if "git cl dommit" will propagate this change or do I need ...
6 years, 7 months ago (2014-05-14 00:31:28 UTC) #4
piman
On Tue, May 13, 2014 at 5:31 PM, <sbc@chromium.org> wrote: > Do you know if ...
6 years, 7 months ago (2014-05-14 00:32:43 UTC) #5
Lei Zhang
I usually just do it from a svn checkout and straight up svn commit, since ...
6 years, 7 months ago (2014-05-14 00:33:41 UTC) #6
Lei Zhang
and lgtm if needed
6 years, 7 months ago (2014-05-14 00:36:18 UTC) #7
Sam Clegg
Committed patchset #1 manually as r270270 (presubmit successful).
6 years, 7 months ago (2014-05-14 00:36:49 UTC) #8
piman
6 years, 7 months ago (2014-05-14 00:38:19 UTC) #9
Message was sent while issue was closed.
On 2014/05/14 00:36:49, Sam Clegg wrote:
> Committed patchset #1 manually as r270270 (presubmit successful).

Seems to have worked.
$ svn proplist
svn://svn.chromium.org/chrome/trunk/src/chrome/installer/linux/sysroot_scripts/sysroot-creator.sh
Properties on
'svn://svn.chromium.org/chrome/trunk/src/chrome/installer/linux/sysroot_scripts/sysroot-creator.sh':
  svn:eol-style

Powered by Google App Engine
This is Rietveld 408576698