Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 284843002: Fix build error with tcmalloc for android (Closed)

Created:
6 years, 7 months ago by JungJik
Modified:
6 years, 7 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org, alkondratenko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix build error with tcmalloc for android malloc_usable_size has been changed in android ndk header. (https://code.google.com/p/android/issues/detail?id=55725) so to override the function properly, this header should be changed too. BUG=162208 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
JungJik
Please PTAL :)
6 years, 7 months ago (2014-05-13 10:55:59 UTC) #1
JungJik
6 years, 7 months ago (2014-05-14 04:16:44 UTC) #2
willchan no longer on Chromium
+gperftools maintainer LGTM
6 years, 7 months ago (2014-05-14 11:30:03 UTC) #3
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 7 months ago (2014-05-15 02:01:03 UTC) #4
JungJik
The CQ bit was unchecked by jungjik.lee@samsung.com
6 years, 7 months ago (2014-05-15 02:01:05 UTC) #5
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 7 months ago (2014-05-15 03:44:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/284843002/1
6 years, 7 months ago (2014-05-15 03:46:10 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 05:36:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 05:39:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67815)
6 years, 7 months ago (2014-05-15 05:39:28 UTC) #10
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 7 months ago (2014-05-16 00:52:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/284843002/1
6 years, 7 months ago (2014-05-16 00:52:58 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 00:58:00 UTC) #13
commit-bot: I haz the power
Failed to apply patch for @master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h: While running svn add @master --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; ...
6 years, 7 months ago (2014-05-16 00:58:00 UTC) #14
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 7 months ago (2014-05-16 01:05:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/284843002/1
6 years, 7 months ago (2014-05-16 01:08:07 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 01:13:17 UTC) #17
commit-bot: I haz the power
Failed to apply patch for @master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h: While running svn add @master --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; ...
6 years, 7 months ago (2014-05-16 01:13:18 UTC) #18
JungJik
On 2014/05/16 01:13:18, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 7 months ago (2014-05-16 10:44:35 UTC) #19
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 7 months ago (2014-05-16 10:44:42 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/284843002/1
6 years, 7 months ago (2014-05-16 10:45:05 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 10:45:52 UTC) #22
commit-bot: I haz the power
Failed to apply patch for @master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h: While running svn add @master --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; ...
6 years, 7 months ago (2014-05-16 10:45:53 UTC) #23
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 7 months ago (2014-05-16 11:47:10 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/284843002/1
6 years, 7 months ago (2014-05-16 11:47:24 UTC) #25
commit-bot: I haz the power
Change committed as 270993
6 years, 7 months ago (2014-05-16 11:48:16 UTC) #26
JungJik
6 years, 7 months ago (2014-05-17 13:51:19 UTC) #27
Message was sent while issue was closed.
On 2014/05/16 11:47:10, Paweł Hajdan Jr. wrote:
> The CQ bit was checked by mailto:phajdan.jr@chromium.org

Thanks for your help. :)

Powered by Google App Engine
This is Rietveld 408576698