|
|
Chromium Code Reviews|
Created:
6 years, 7 months ago by JungJik Modified:
6 years, 7 months ago CC:
chromium-reviews, dmikurube+memory_chromium.org, alkondratenko Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionFix build error with tcmalloc for android
malloc_usable_size has been changed in android ndk header.
(https://code.google.com/p/android/issues/detail?id=55725)
so to override the function properly, this header should be changed too.
BUG=162208
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270993
Patch Set 1 #
Messages
Total messages: 27 (0 generated)
Please PTAL :)
+gperftools maintainer LGTM
The CQ bit was checked by jungjik.lee@samsung.com
The CQ bit was unchecked by jungjik.lee@samsung.com
The CQ bit was checked by jungjik.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/284843002/1
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was checked by jungjik.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/284843002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
svn: '@master' is just a peg revision. Maybe try '@master@' instead?
Patch:
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
Index: third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
diff --git
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
index
3b858caa444261e5d36e6586fb3f39eb46c29907..2204dfd50738808af959a9ef9b33ac2620a83a85
100644
--- a/@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
+++ b/@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
@@ -94,7 +94,12 @@ extern "C" {
struct mallinfo mallinfo(void) __THROW ALIAS(tc_mallinfo);
#endif
size_t malloc_size(void* p) __THROW ALIAS(tc_malloc_size);
+#if defined(__ANDROID__)
+ size_t malloc_usable_size(const void* p) __THROW
+ ALIAS(tc_malloc_size);
+#else
size_t malloc_usable_size(void* p) __THROW ALIAS(tc_malloc_size);
+#endif
} // extern "C"
#undef ALIAS
The CQ bit was checked by jungjik.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/284843002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
svn: '@master' is just a peg revision. Maybe try '@master@' instead?
Patch:
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
Index: third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
diff --git
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
index
3b858caa444261e5d36e6586fb3f39eb46c29907..2204dfd50738808af959a9ef9b33ac2620a83a85
100644
--- a/@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
+++ b/@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
@@ -94,7 +94,12 @@ extern "C" {
struct mallinfo mallinfo(void) __THROW ALIAS(tc_mallinfo);
#endif
size_t malloc_size(void* p) __THROW ALIAS(tc_malloc_size);
+#if defined(__ANDROID__)
+ size_t malloc_usable_size(const void* p) __THROW
+ ALIAS(tc_malloc_size);
+#else
size_t malloc_usable_size(void* p) __THROW ALIAS(tc_malloc_size);
+#endif
} // extern "C"
#undef ALIAS
On 2014/05/16 01:13:18, I haz the power (commit-bot) wrote:
> Failed to apply patch for
> @master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h:
> While running svn add @master --force --config-dir
> /b/infra_internal/commit_queue/subversion_config --non-interactive;
> svn: '@master' is just a peg revision. Maybe try '@master@' instead?
>
> Patch:
> @master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
> Index: third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
> diff --git
> @master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
> @master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
> index
>
3b858caa444261e5d36e6586fb3f39eb46c29907..2204dfd50738808af959a9ef9b33ac2620a83a85
> 100644
> --- a/@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
> +++ b/@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
> @@ -94,7 +94,12 @@ extern "C" {
> struct mallinfo mallinfo(void) __THROW ALIAS(tc_mallinfo);
> #endif
> size_t malloc_size(void* p) __THROW ALIAS(tc_malloc_size);
> +#if defined(__ANDROID__)
> + size_t malloc_usable_size(const void* p) __THROW
> + ALIAS(tc_malloc_size);
> +#else
> size_t malloc_usable_size(void* p) __THROW ALIAS(tc_malloc_size);
> +#endif
> } // extern "C"
>
> #undef ALIAS
Could you help me? Is this a commit-bot problem?
The CQ bit was checked by jungjik.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/284843002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
svn: '@master' is just a peg revision. Maybe try '@master@' instead?
Patch:
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
Index: third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
diff --git
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
index
3b858caa444261e5d36e6586fb3f39eb46c29907..2204dfd50738808af959a9ef9b33ac2620a83a85
100644
--- a/@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
+++ b/@master/third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
@@ -94,7 +94,12 @@ extern "C" {
struct mallinfo mallinfo(void) __THROW ALIAS(tc_mallinfo);
#endif
size_t malloc_size(void* p) __THROW ALIAS(tc_malloc_size);
+#if defined(__ANDROID__)
+ size_t malloc_usable_size(const void* p) __THROW
+ ALIAS(tc_malloc_size);
+#else
size_t malloc_usable_size(void* p) __THROW ALIAS(tc_malloc_size);
+#endif
} // extern "C"
#undef ALIAS
The CQ bit was checked by phajdan.jr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/284843002/1
Message was sent while issue was closed.
Change committed as 270993
Message was sent while issue was closed.
On 2014/05/16 11:47:10, Paweł Hajdan Jr. wrote: > The CQ bit was checked by mailto:phajdan.jr@chromium.org Thanks for your help. :) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
