Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 28483002: Remove fileapi::FileSystemFileUtil dependency from chrome/ syncfs code (Closed)

Created:
7 years, 2 months ago by kinuko
Modified:
7 years, 2 months ago
Reviewers:
Avi (use Gerrit), tzik
CC:
chromium-reviews, tzik, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, nhiroki+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Remove fileapi::FileSystemFileUtil dependency from chrome/ syncfs code BUG=265770 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kinuko
Usual cleanup stuff... still need more cleanups. PTL
7 years, 2 months ago (2013-10-18 07:10:51 UTC) #1
tzik
lgtm
7 years, 2 months ago (2013-10-18 08:07:24 UTC) #2
kinuko
avi: can you do owner's review for content/content_tests.gypi changes?
7 years, 2 months ago (2013-10-18 08:13:45 UTC) #3
Avi (use Gerrit)
lgtm
7 years, 2 months ago (2013-10-18 14:56:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/28483002/1
7 years, 2 months ago (2013-10-20 04:51:34 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=90845
7 years, 2 months ago (2013-10-20 11:21:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/28483002/1
7 years, 2 months ago (2013-10-21 03:05:36 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-21 05:06:08 UTC) #8
Message was sent while issue was closed.
Change committed as 229740

Powered by Google App Engine
This is Rietveld 408576698