Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: components/data_reduction_proxy/core/common/lofi_ui_service.h

Issue 2848293002: Adding the Previews infobar to pages that show a client LoFi image (Closed)
Patch Set: sclittle comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/common/lofi_ui_service.h
diff --git a/components/data_reduction_proxy/core/common/lofi_ui_service.h b/components/data_reduction_proxy/core/common/lofi_ui_service.h
index 656dab4de9bd51c2e39f9e14a1f06a79c4a6f3f2..0b17579eb3a39baa07627d8ff3d12cc4f0642e19 100644
--- a/components/data_reduction_proxy/core/common/lofi_ui_service.h
+++ b/components/data_reduction_proxy/core/common/lofi_ui_service.h
@@ -20,7 +20,10 @@ class LoFiUIService {
virtual ~LoFiUIService() {}
// Notifies the UI thread that |request| has a Lo-Fi response.
- virtual void OnLoFiReponseReceived(const net::URLRequest& request) = 0;
+ // |is_server_lofi| is whether this was a client LoFi optimization or a server
sclittle 2017/05/03 22:51:30 nit: s/client LoFi/Client Lo-Fi/
RyanSturm 2017/05/03 23:20:30 Done.
+ // LoFi optimization.
sclittle 2017/05/03 22:51:30 nit: for consistency, could you hyphenate LoFi as
RyanSturm 2017/05/03 23:20:30 Done.
+ virtual void OnLoFiReponseReceived(const net::URLRequest& request,
+ bool is_server_lofi) = 0;
};
} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698