components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc - Issue 2848293002: Adding the Previews infobar to pages that show a client LoFi image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

Issue 2848293002: Adding the Previews infobar to pages that show a client LoFi image (Closed)

Patch Set: removed range check Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/previews/previews_infobar_delegate.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

index 6752c415e7861dbec641209707bdcbf868b57226..dcba55a78278e4d2969d01def100cdde46f86960 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

@@ -380,10 +380,17 @@ void DataReductionProxyNetworkDelegate::OnCompletedInternal(

net_error);

net::HttpRequestHeaders request_headers;

- if (data_reduction_proxy_io_data_ && request->response_headers() &&

- IsEmptyImagePreview(*(request->response_headers()))) {

+ bool server_lofi = data_reduction_proxy_io_data_ &&

+ request->response_headers() &&

+ IsEmptyImagePreview(*(request->response_headers()));

+ bool client_lofi =

+ !server_lofi && data_reduction_proxy_io_data_ &&

+ data_reduction_proxy_io_data_->lofi_decider() &&

+ data_reduction_proxy_io_data_->lofi_decider()->IsClientLoFiImageRequest(

+ *request);

+ if (server_lofi || client_lofi) {

data_reduction_proxy_io_data_->lofi_ui_service()->OnLoFiReponseReceived(

- *request);

+ *request, server_lofi /* is_server_lofi */);

} else if (data_reduction_proxy_io_data_ && request->response_headers() &&

IsLitePagePreview(*(request->response_headers()))) {

RecordLitePageTransformationType(LITE_PAGE);