Adding the Previews infobar to pages that show a client LoFi image

chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "build/build_config.h"
 #include "chrome/browser/net/spdyproxy/chrome_data_use_group_provider.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
 #include "chrome/browser/previews/previews_infobar_delegate.h"
+#include "chrome/browser/previews/previews_service.h"
+#include "chrome/browser/previews/previews_service_factory.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/common/channel_info.h"
 #include "chrome/common/chrome_content_client.h"
 #include "chrome/common/pref_names.h"
 #include "components/data_reduction_proxy/content/browser/content_lofi_decider.h"
 #include "components/data_reduction_proxy/content/browser/content_lofi_ui_service.h"
 #include "components/data_reduction_proxy/content/browser/content_resource_type_provider.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
 #include "components/prefs/pref_service.h"
+#include "components/previews/core/previews_experiments.h"
+#include "components/previews/core/previews_ui_service.h"
 #include "components/version_info/version_info.h"
+#include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/navigation_controller.h"
+#include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents.h"
+#include "url/gurl.h"
 
 #if defined(OS_ANDROID)
 #include "base/android/build_info.h"
 #endif
 
 namespace content {
 class BrowserContext;
 }
 
 using data_reduction_proxy::DataReductionProxyParams;
 
 namespace {
 
+// Adds the preview navigation to the black list.
+void AddPreviewNavigationToBlackListCallback(
+    content::BrowserContext* browser_context,
+    const GURL& url,
+    previews::PreviewsType type,
+    bool opt_out) {
+  PreviewsService* previews_service = PreviewsServiceFactory::GetForProfile(
+      Profile::FromBrowserContext(browser_context));
+  if (previews_service && previews_service->previews_ui_service()) {
+    previews_service->previews_ui_service()->AddPreviewNavigation(url, type,
+                                                                  opt_out);
+  }
+}
+
 // If this is the first Lo-Fi response for a page load, a
 // PreviewsInfoBarDelegate is created, which handles showing Lo-Fi UI.
-void OnLoFiResponseReceivedOnUI(content::WebContents* web_contents) {
+void OnLoFiResponseReceivedOnUI(content::WebContents* web_contents,
+                                bool is_server_lofi) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
-  PreviewsInfoBarDelegate::Create(
-      web_contents, PreviewsInfoBarDelegate::LOFI,
-      true /* is_data_saver_user */,
-      PreviewsInfoBarDelegate::OnDismissPreviewsInfobarCallback());
+  if (is_server_lofi) {

[sclittle, 2017/05/03 22:51:29]

If both Server and Client LoFi are used on a page, and Server LoFi wins the
race, it looks like we're avoiding updating the blacklist here.

What if we just add it to the blacklist in either case? That way, Client LoFi
can use the blacklist, Server LoFi can continue to ignore the blacklist for now,
and in the future when Server LoFi is moved onto the blacklist, it'll already
have a bunch of history.

Also, if Client LoFi was used, and we don't add it to the blacklist here, does
that mean that the blacklist think that Client LoFi worked fine on the page,
e.g. regarding the 2 out of the last 4 pages rule?

[RyanSturm, 2017/05/03 23:20:29]

Good Point. I was trying to land these CLs side-by-side since there isn't
support for LitePage/ServerLofi in the blacklsit just yet.

+    PreviewsInfoBarDelegate::Create(
+        web_contents, PreviewsInfoBarDelegate::LOFI,
+        true /* is_data_saver_user */,
+        PreviewsInfoBarDelegate::OnDismissPreviewsInfobarCallback());
+  } else {
+    PreviewsInfoBarDelegate::Create(
+        web_contents, PreviewsInfoBarDelegate::LOFI,
+        true /* is_data_saver_user */,
+        base::Bind(&AddPreviewNavigationToBlackListCallback,
+                   web_contents->GetBrowserContext(),
+                   web_contents->GetController()
+                       .GetLastCommittedEntry()
+                       ->GetRedirectChain()[0],
+                   previews::PreviewsType::CLIENT_LOFI));
+  }
 }
 
 } // namespace
 
 std::unique_ptr<data_reduction_proxy::DataReductionProxyIOData>
 CreateDataReductionProxyChromeIOData(
     net::NetLog* net_log,
     PrefService* prefs,
     const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
     const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner) {
@@ skipping 27 matching lines @@
   data_reduction_proxy_io_data->set_resource_type_provider(
       base::MakeUnique<data_reduction_proxy::ContentResourceTypeProvider>());
   data_reduction_proxy_io_data->set_lofi_ui_service(
       base::MakeUnique<data_reduction_proxy::ContentLoFiUIService>(
           ui_task_runner, base::Bind(&OnLoFiResponseReceivedOnUI)));
   data_reduction_proxy_io_data->set_data_usage_source_provider(
       base::MakeUnique<ChromeDataUseGroupProvider>());
 
   return data_reduction_proxy_io_data;
 }