Adding the Previews infobar to pages that show a client LoFi image

chrome/browser/previews/previews_infobar_delegate.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/previews/previews_infobar_delegate.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/optional.h"
 #include "chrome/browser/android/android_theme_resources.h"
 #include "chrome/browser/infobars/infobar_service.h"
@@ skipping 10 matching lines @@
 
 namespace {
 
 // Key of the UMA Previews.InfoBarAction.LoFi histogram.
 const char kUMAPreviewsInfoBarActionLoFi[] = "Previews.InfoBarAction.LoFi";
 
 // Key of the UMA Previews.InfoBarAction.Offline histogram.
 const char kUMAPreviewsInfoBarActionOffline[] =
     "Previews.InfoBarAction.Offline";
 
+// Key of the UMA Previews.InfoBarAction.ClientLoFi histogram.
+const char kUMAPreviewsInfoBarActionClientLoFi[] =
+    "Previews.InfoBarAction.ClientLoFi";
+
 // Key of the UMA Previews.InfoBarAction.LitePage histogram.
 const char kUMAPreviewsInfoBarActionLitePage[] =
     "Previews.InfoBarAction.LitePage";
 
 void RecordPreviewsInfoBarAction(
     PreviewsInfoBarDelegate::PreviewsInfoBarType infobar_type,
     PreviewsInfoBarDelegate::PreviewsInfoBarAction action) {
   if (infobar_type == PreviewsInfoBarDelegate::LOFI) {
     UMA_HISTOGRAM_ENUMERATION(kUMAPreviewsInfoBarActionLoFi, action,
                               PreviewsInfoBarDelegate::INFOBAR_INDEX_BOUNDARY);
   } else if (infobar_type == PreviewsInfoBarDelegate::LITE_PAGE) {
     UMA_HISTOGRAM_ENUMERATION(kUMAPreviewsInfoBarActionLitePage, action,
                               PreviewsInfoBarDelegate::INFOBAR_INDEX_BOUNDARY);
   } else if (infobar_type == PreviewsInfoBarDelegate::OFFLINE) {
     UMA_HISTOGRAM_ENUMERATION(kUMAPreviewsInfoBarActionOffline, action,
                               PreviewsInfoBarDelegate::INFOBAR_INDEX_BOUNDARY);
+  } else if (infobar_type == PreviewsInfoBarDelegate::CLIENT_LOFI) {
+    UMA_HISTOGRAM_ENUMERATION(kUMAPreviewsInfoBarActionClientLoFi, action,
+                              PreviewsInfoBarDelegate::INFOBAR_INDEX_BOUNDARY);
   }
 }
 
 }  // namespace
 
 PreviewsInfoBarDelegate::~PreviewsInfoBarDelegate() {
   if (!on_dismiss_callback_.is_null())
     on_dismiss_callback_.Run(false);
 
   RecordPreviewsInfoBarAction(infobar_type_, infobar_dismissed_action_);
@@ skipping 100 matching lines @@
     PreviewsInfoBarTabHelper* infobar_tab_helper =
         PreviewsInfoBarTabHelper::FromWebContents(web_contents);
     if (infobar_tab_helper &&
         infobar_tab_helper->committed_data_saver_navigation_id()) {
       data_reduction_proxy_settings->data_reduction_proxy_service()
           ->pingback_client()
           ->AddOptOut(
               infobar_tab_helper->committed_data_saver_navigation_id().value());
     }
 
-    if (infobar_type_ == LITE_PAGE)
+    if (infobar_type_ == LITE_PAGE) {
       web_contents->GetController().Reload(
           content::ReloadType::DISABLE_LOFI_MODE, true);
-    else if (infobar_type_ == LOFI)
+    } else if (infobar_type_ == LOFI) {
       web_contents->ReloadLoFiImages();
+    }
+  } else if (infobar_type_ == CLIENT_LOFI) {
+    web_contents->ReloadLoFiImages();

[sclittle, 2017/05/03 18:40:21]

If "Show Original" is clicked on a page with both Server and Client LoFi, and
Client LoFi is seen first and used for the infobar, then does this mean that
none of the above DRP opt-out stuff happens?

[RyanSturm, 2017/05/03 18:48:52]

Yes. It's definitely a race between the two. What percent of server LoFi page
loads are expected to use both types of LoFi. I expect an HTTP page with ads
would be a clear example. 

[sclittle, 2017/05/03 19:02:46]

http:// pages with ads/analytics/social widgets are the main example. I don't
know the actual percentage, but I'd guess that most http:// pages have at least
one of those kinds of https:// resources on them, which implies that almost all
pages that use Server LoFi will also use Client LoFi.

   } else if (infobar_type_ == OFFLINE) {
     // Prevent LoFi and lite page modes from showing after reload.
     // TODO(ryansturm): rename DISABLE_LOFI_MODE to DISABLE_PREVIEWS.
     //  crbug.com/707272
     web_contents->GetController().Reload(content::ReloadType::DISABLE_LOFI_MODE,
                                          true);
   }
 
   return true;
 }