Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2848243002: Register local functions with async markers (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Register local functions with async markers - in kernel computation of WorldImpact. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/6a575117630f40859b4fc034696e9a14486501d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -5 lines) Patch
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 4 chunks +11 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-01 10:44:39 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-02 19:35:28 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-03 08:32:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a575117630f40859b4fc034696e9a14486501d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698