Calling focus() on an iframe should not trigger a 'focusout' event

Calling focus() on an iframe should not trigger a 'focusout' event

Update Element::updateFocusAppearance() so that calling focus() on an iframe
no longer triggers a 'focusout' event. The issue was that Element:focus() would
call focusController().setFocusedElement() to set focus to the given element
and then call updateFocusAppearance() which would potentially steal the focus
and give it to another Element. This is because updateFocusAppearance() calls
FrameSelection::setSelection() which set focus unless explicitely told
otherwise using the DoNotSetFocus option.

This CL updates updateFocusAppearance() to pass DoNotSetFocus option when
calling FrameSelection::setSelection() to maintain the focused Element
previously set by Element::focus().

The new behavior is in line with Firefox 29 and IE11.

R=eseidel@chromium.org, ojan@chromium.org
TEST=fast/frames/frame-focus-no-focusout-event.html
BUG=372777
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175017

[Inactive, 2014-05-16 13:38:00]

post BlinkOn ping? :)

[Inactive, 2014-05-20 11:59:44]

Eric, Ojan, is this something you can/want to review?

Could you please advise an alternative OWNER if you'd prefer someone else to
review this?

[eseidel, 2014-05-29 00:08:20]

Does this match behavior of FF/IE, etc?

Rick is staring into the depths of focus() atm and may have further thoughts.

lgtm if this new behavior brings us more in line with other browsers.

[Inactive, 2014-05-29 00:39:00]

On 2014/05/29 00:08:20, eseidel wrote:
> Does this match behavior of FF/IE, etc?
> 
> Rick is staring into the depths of focus() atm and may have further thoughts.
> 
> lgtm if this new behavior brings us more in line with other browsers.

Yes, I have verified using http://jsbin.com/sitij/quiet that both Firefox 29 and
IE11 do not fire a focusout event in this case.

[Inactive, 2014-05-29 00:39:12]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-05-29 00:39:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/284823005/1

[commit-bot: I haz the power, 2014-05-29 00:52:44]

Change committed as 175017

[Rick Byers, 2014-05-29 02:14:56]

Yep, this sounds like the right change to me - thanks!

[Inactive, 2014-05-29 12:16:56]

On 2014/05/29 02:14:56, Rick Byers wrote:
> Yep, this sounds like the right change to me - thanks!

Great, thanks for taking a look Rick.